【BUPT】【Paddle Tensor 第二期 API支持 0-size Tensor】paddle.matrix_rank 支持 0-size tensor #70130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Comment on lines
98
to
104
| "be 0, but shape is %s now.", | ||
| dim_x)); | ||
| PADDLE_ENFORCE_NE( | ||
| cols, | ||
| 0, | ||
| errors::InvalidArgument("The input Tensor x's shape[-1] should not " | ||
| "be 0, but shape is %s now.", |
There was a problem hiding this comment.
but shape is --> but received
| @@ -474,5 +476,70 @@ def test_errors(self): | |||
| paddle.linalg.matrix_rank(x, tol=0.2, hermitian=True, rtol=0.2) | |||
|
|
|||
|
|
|||
| class TestMatrixRankAtolRtolEmptyTensor(unittest.TestCase): | |||
There was a problem hiding this comment.
Suggested change
| class TestMatrixRankAtolRtolEmptyTensor(unittest.TestCase): | |
| class TestMatrixRankAtolRtolZeroSizeTensor(unittest.TestCase): |
| "be 0, but shape is %s now.", | ||
| dim_x)); | ||
| if (x.numel() == 0) { | ||
| out->Resize({0}); |
There was a problem hiding this comment.
假设输入的形状是[..., m, n]，输出的形状应该是[...]，而不是[0]
74 tasks
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Bug fixes
Description
解决matrix_rank不支持0 size 的问题
