【SCU】[Paddle TensorRT No.28] Add pd_op.logical_xor converter #69958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
kineast seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
added 2 commits
December 5, 2024 02:59
added 2 commits
December 9, 2024 08:13
lizexu123
reviewed
Dec 11, 2024
| auto x_dtype = pir::GetDataTypeFromValue(x); | ||
| auto y_dtype = pir::GetDataTypeFromValue(y); | ||
| if (!(x_dtype.isa<pir::BoolType>() && y_dtype.isa<pir::BoolType>())) { | ||
| VLOG(3) << "pd_op.logical_xor op only supports bool datatype"; |
There was a problem hiding this comment.
这个可以参考下pd_op.logical_or那个pr的写法，这三个共用一个class，你这里叫做pd_op.logical_xor不合适
|
Sorry to inform you that 3886d7f's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User ExperiencePR Types
New featuresDescription
新增了pd_op.logical_xor Marker和Converter