Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【SCU】【Paddle TensorRT No.23】Add pd_op.elementwise_pow converter #69580

Merged
merged 10 commits into from
Dec 20, 2024

Conversation

PolaKuma
Copy link
Contributor

@PolaKuma PolaKuma commented Nov 21, 2024

PR Category

User Experience

PR Types

New features

Description

新增了pd_op.elementwise_pow Marker和Converter

Copy link

paddle-bot bot commented Nov 21, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 21, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Nov 21, 2024
@@ -65,6 +65,7 @@ DEFINE_GENERAL_PATTERN(Fused_gemm_epilogue,
paddle::dialect::FusedGemmEpilogueOp)
DEFINE_GENERAL_PATTERN(Layer_norm, paddle::dialect::LayerNormOp)
DEFINE_GENERAL_PATTERN(Add, paddle::dialect::AddOp)
DEFINE_GENERAL_PATTERN(Pow, paddle::dialect::PowOp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该是paddle::dialect::ElementwisePowOp



@converter_registry.register("pd_op.elementwise_pow", trt_version="8.x")
def elementwise_pow_converter(network, paddle_op, inputs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个写成一个,并且不要复用这个函数,自己按照elementwise_op.cc中写一个

@@ -95,6 +95,21 @@ def test_trt_result(self):
self.check_trt_result()


class TestPowTRTPattern(TensorRTBaseTest):
def setUp(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuanRisheng
Copy link
Contributor

注意pd_op.pow和pd_op.elementwise_pow是俩个算子,pd_op.pow是一个输入Tensor,pd_op.elementwise_pow是俩个输入Tensor,如果你的pr实现的是pd_op.elementwise_pow,那对应注册converter的时候需要注册pd_op.elementwise_pow

@PolaKuma
Copy link
Contributor Author

注意pd_op.pow和pd_op.elementwise_pow是俩个算子,pd_op.pow是一个输入Tensor,pd_op.elementwise_pow是俩个输入Tensor,如果你的pr实现的是pd_op.elementwise_pow,那对应注册converter的时候需要注册pd_op.elementwise_pow

好的,感谢纠正,我再修改一下

Copy link

paddle-ci-bot bot commented Dec 12, 2024

Sorry to inform you that b833b7c's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@PolaKuma
Copy link
Contributor Author

@lizexu123 老师这个还需要您review下~

@PolaKuma PolaKuma requested a review from lizexu123 December 20, 2024 01:28
@YuanRisheng YuanRisheng merged commit 984dfaf into PaddlePaddle:develop Dec 20, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants