[Paddle TensorRT No.42、45] Add (pd_op.isnan、pd_op.embedding) converter
#69435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… pir_tensorrt_isnan_embedding
ooooo-create
changed the title
pd_op.isnan、pd_op.embedding) converter
lizexu123
reviewed
Nov 25, 2024
python/paddle/tensorrt/impls/math.py
Outdated
| return cast_layer.get_output(0) | ||
|
|
||
|
|
||
| @converter_registry.register("pd_op.isnan", trt_version="trt_version_ge=10.1") |
|
Sorry to inform you that 418f978's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
… pir_tensorrt_isnan_embedding
ooooo-create
force-pushed
the
pir_tensorrt_isnan_embedding
branch
from
418f978 to
0e6a344
Compare
lizexu123
previously approved these changes
Dec 23, 2024
YuanRisheng
reviewed
Dec 23, 2024
Comment on lines
1424
to
1429
| if (pir::GetDefiningOpForInput(op, 1)->name() == "builtin.parameter") { | ||
| // trt.Weights don't have the shape info. | ||
| VLOG(3) << "Skip to convert into TRT while found weight is a parameter " | ||
| "in pd_op.embedding."; | ||
| return false; | ||
| } |
There was a problem hiding this comment.
这里逻辑有问题吧，为啥parameter不进trt，大部分应该都是parameter的场景
There was a problem hiding this comment.
当时以为 parameter 进入 trt 之后都是一维的，没有形状信息，计算不了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Inference
PR Types
New features
Description