Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Infer Symbolic Shape No.201】[BUAA] Add graph_khop_sampler #67690

Merged
merged 6 commits into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1298,12 +1298,82 @@ bool FusedMultiTransformerOpInferSymbolicShape(
// return true;
// }

// bool GraphKhopSamplerOpInferSymbolicShape(pir::Operation *op,
// pir::InferSymbolicShapeContext
// *infer_context) {
// // pass
// return true;
// }
bool GraphKhopSamplerOpInferSymbolicShape(
pir::Operation *op, pir::InferSymbolicShapeContext *infer_context) {
const symbol::ShapeOrDataDimExprs &row_shape_or_data =
infer_context->GetShapeOrDataForValue(op->operand_source(0));
const symbol::ShapeOrDataDimExprs &col_ptr_shape_or_data =
infer_context->GetShapeOrDataForValue(op->operand_source(1));
const symbol::ShapeOrDataDimExprs &x_shape_or_data =
infer_context->GetShapeOrDataForValue(op->operand_source(2));
const symbol::ShapeOrDataDimExprs &eids_shape_or_data =
infer_context->GetShapeOrDataForValue(op->operand_source(3));

auto row_shape = row_shape_or_data.shape();
auto col_ptr_shape = col_ptr_shape_or_data.shape();
auto x_shape = x_shape_or_data.shape();
auto eids_shape = eids_shape_or_data.shape();
Copy link
Contributor

@gongshaotian gongshaotian Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非必需不使用auto,这个四个变量可以直接使用具体类型的 const 引用


auto GKSShapeCheck = [&](const std::vector<symbol::DimExpr> &shape,
const std::string &tensor_name) {
if (shape.size() == 2)
infer_context->AddEqualCstr(shape[1], symbol::DimExpr(1));
else
PADDLE_ENFORCE_EQ(
shape.size(),
1,
common::errors::InvalidArgument(
"The %s should be 1D, when it is not 2D, but we get %d",
tensor_name,
shape.size()));
};

GKSShapeCheck(row_shape, "row");
GKSShapeCheck(col_ptr_shape, "col_ptr");
GKSShapeCheck(x_shape, "x");

std::vector<int> sample_sizes =
paddle::dialect::details::GetVectorAttr<int>(op, "sample_sizes");
PADDLE_ENFORCE_EQ(
!sample_sizes.empty(),
true,
common::errors::InvalidArgument(
"The parameter 'sample_sizes' in GraphSampleOp must be set. "
"But received 'sample_sizes' is empty."));

bool return_eids = op->attribute<pir::BoolAttribute>("return_eids").data();
if (return_eids) {
GKSShapeCheck(eids_shape, "eids");
symbol::DimExpr out_unknown_4 = infer_context->GetNextSymName();
infer_context->SetShapeOrDataForValue(
op->result(4),
symbol::ShapeOrDataDimExprs{
symbol::TensorShapeOrDataDimExprs({out_unknown_4})});
} else {
infer_context->SetSymbolForValueByStaticShape(op->result(4));
}

symbol::DimExpr out_unknown_0_1 = infer_context->GetNextSymName();
symbol::DimExpr out_unknown_2 = infer_context->GetNextSymName();
infer_context->SetShapeOrDataForValue(
op->result(0),
symbol::ShapeOrDataDimExprs{
symbol::TensorShapeOrDataDimExprs({out_unknown_0_1, 1})});
infer_context->SetShapeOrDataForValue(
op->result(1),
symbol::ShapeOrDataDimExprs{
symbol::TensorShapeOrDataDimExprs({out_unknown_0_1, 1})});
infer_context->SetShapeOrDataForValue(
op->result(2),
symbol::ShapeOrDataDimExprs{
symbol::TensorShapeOrDataDimExprs({out_unknown_2})});
infer_context->SetShapeOrDataForValue(
op->result(3),
symbol::ShapeOrDataDimExprs{
symbol::TensorShapeOrDataDimExprs({x_shape[0]})});

return true;
}

// bool GraphReindexOpInferSymbolicShape(pir::Operation *op,
// pir::InferSymbolicShapeContext
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ OP_DECLARE_INFER_SYMBOLIC_SHAPE(FusedBnAddActivation)
OP_DECLARE_INFER_SYMBOLIC_SHAPE(FusedBnAddActivation_)
OP_DECLARE_INFER_SYMBOLIC_SHAPE(FusedMultiTransformer)
// OP_DECLARE_INFER_SYMBOLIC_SHAPE(GenerateProposals)
// OP_DECLARE_INFER_SYMBOLIC_SHAPE(GraphKhopSampler)
OP_DECLARE_INFER_SYMBOLIC_SHAPE(GraphKhopSampler)
// OP_DECLARE_INFER_SYMBOLIC_SHAPE(GraphReindex)
// OP_DECLARE_INFER_SYMBOLIC_SHAPE(GraphSampleNeighbors)
// OP_DECLARE_INFER_SYMBOLIC_SHAPE(Gru)
Expand Down
2 changes: 1 addition & 1 deletion paddle/phi/ops/yaml/ops.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2281,7 +2281,7 @@
func : graph_khop_sampler
data_type : row
optional : eids
# interfaces : paddle::dialect::InferSymbolicShapeInterface
interfaces : paddle::dialect::InferSymbolicShapeInterface

- op : graph_sample_neighbors
args : (Tensor row, Tensor colptr, Tensor x, Tensor eids, Tensor perm_buffer, int sample_size, bool return_eids, bool flag_perm_buffer)
Expand Down