Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th Fundable Projects 3 No.53】 [fluid_ops] c_sync_comm_stream #66798

Closed
wants to merge 7 commits into from

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Jul 30, 2024

PR Category

Operator Mechanism

PR Types

Others

Description

53 c_sync_comm_stream 改名 sync_comm_stream

Copy link

paddle-bot bot commented Jul 30, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 30, 2024
@co63oc co63oc force-pushed the fix_comm_stream branch 5 times, most recently from 368a3c8 to 39eb2fd Compare August 8, 2024 00:12
@co63oc co63oc closed this Aug 10, 2024
@co63oc co63oc reopened this Aug 10, 2024
@co63oc co63oc force-pushed the fix_comm_stream branch 2 times, most recently from 6f757da to fd55ee9 Compare August 16, 2024 00:41
@co63oc co63oc force-pushed the fix_comm_stream branch 4 times, most recently from 7363b18 to dee74df Compare August 30, 2024 02:00
Copy link

paddle-ci-bot bot commented Sep 7, 2024

Sorry to inform you that e8a3d78's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

liym27
liym27 previously approved these changes Sep 19, 2024
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@co63oc co63oc changed the title CI测试不review [fluid_ops] c_sync_comm_stream 【Hackathon 6th Fundable Projects 3 No.53】 [fluid_ops] c_sync_comm_stream Sep 19, 2024
@@ -255,7 +255,7 @@ def _sync_calc_stream(tensor):

def _sync_comm_stream(tensor, ring_id=0):
if framework.in_dynamic_mode():
return paddle._legacy_C_ops.c_sync_comm_stream(
return paddle._legacy_C_ops.sync_comm_stream(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里_legacy_C_ops可以换成_C_ops吗?

@co63oc
Copy link
Contributor Author

co63oc commented Sep 27, 2024

使用 #66744

@co63oc co63oc closed this Sep 27, 2024
@co63oc co63oc deleted the fix_comm_stream branch September 27, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants