【Fix PIR Unittest No.232,528 BUAA】Fix some test case in PIR #66152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
| @@ -468,7 +468,6 @@ endif() | |||
| foreach(TEST_OP ${TEST_OPS}) | |||
| py_test_modules(${TEST_OP} MODULES ${TEST_OP}) | |||
| endforeach() | |||
| set_tests_properties(test_logcumsumexp_op PROPERTIES TIMEOUT 30) | |||
There was a problem hiding this comment.
这个需要一起迁移到 test/legacy_test 下嘛
There was a problem hiding this comment.
这行代码需要迁移到test/legacy_test/CMakeLists.txt下的，这个是设置单测timeout时间的，说明这个单测跑的比较慢，可能偶发性导致CI超时。
… test_logcumsumexp_op upstream
Closed
wanghuancoder
approved these changes
Jul 19, 2024
| @@ -468,7 +468,6 @@ endif() | |||
| foreach(TEST_OP ${TEST_OPS}) | |||
| py_test_modules(${TEST_OP} MODULES ${TEST_OP}) | |||
| endforeach() | |||
| set_tests_properties(test_logcumsumexp_op PROPERTIES TIMEOUT 30) | |||
There was a problem hiding this comment.
这行代码需要迁移到test/legacy_test/CMakeLists.txt下的，这个是设置单测timeout时间的，说明这个单测跑的比较慢，可能偶发性导致CI超时。
Marcusryz
changed the title
|
@Marcusryz 请根据review意见处理下 |
已经处理了 |
Marcusryz
changed the title
Marcusryz
changed the title
inaomIIsfarell
pushed a commit
to inaomIIsfarell/Paddle
that referenced
this pull request
Jul 31, 2024
…66152) * Fix some bugs in test_logcumsumexp_op when PIR not support .name. * Add TIMEOUT SETTING for test_logsumcumexp_op.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Others
PR Types
Others
Description
Fix test_crop_op.
PIR 不支持 .name，所以这个 test_name 可以跳过 PIR 的测试。
使用 with paddle.pir_utils.OldIrGuard() 包裹问题代码块。
关联 issue：#63740
Pcard-67164