remove unuseful c_allgather op for pir auto parallel. #64465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
winter-wang
changed the title
JZ-LIANG
approved these changes
May 20, 2024
| ) | ||
| elif isinstance(self._optimizer._learning_rate, LRScheduler): | ||
| buffer_tensor.set( | ||
| np.float32(self._optimizer._learning_rate()), self._place |
There was a problem hiding this comment.
是否会 触发 lr_schedule 的迭代，让动静lr 无法对齐
There was a problem hiding this comment.
是的，这个问题我会在下个pr中进行专门的系统性处理。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Auto Parallel
PR Types
Bug fixes
Description
Other
Pcard-67164