Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR][oneDNN] Support attribute transformation of ArrayAttribute<pir::Int64Attribute> in oneDNN instruction #64441

Merged
merged 2 commits into from
May 27, 2024
Merged

[PIR][oneDNN] Support attribute transformation of ArrayAttribute<pir::Int64Attribute> in oneDNN instruction #64441

merged 2 commits into from
May 27, 2024

Conversation

LLee233
Copy link
Contributor

@LLee233 LLee233 commented May 20, 2024

PR Category

Others

PR Types

New features

Description

In former oneDNN instruction, there is no support for ArrayAttribute<pir::Int64Attribute> transformation, which might cause error when running oneDNN pir passes. Hence we add new case to support it.

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented May 20, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@LLee233 LLee233 requested a review from wanghuancoder May 20, 2024 03:10
@paddle-bot paddle-bot bot added the contributor External developers label May 20, 2024
@LLee233 LLee233 added the Intel label May 20, 2024
@LLee233
Copy link
Contributor Author

LLee233 commented May 20, 2024

Hi @onecatcn, could you please helping find approver for this PR? Cause it changes new_executor and needs extra RD approving. Thanks!

2024-05-20 11:16:37 ****************
2024-05-20 11:16:37 0. You must have one RD (From00, zhangbo9674) approval for file changes in paddle/fluid/framework/new_executor.
2024-05-20 11:16:37 There are 1 approved errors.
2024-05-20 11:16:37 ****************

@onecatcn onecatcn requested a review from From00 May 21, 2024 02:52
wanghuancoder
wanghuancoder previously approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LLee233 LLee233 force-pushed the support_int64_array branch from 7fe5d9e to 67169c0 Compare May 22, 2024 02:27
@LLee233
Copy link
Contributor Author

LLee233 commented May 23, 2024

@onecatcn Hi, could you help check the CI status? I saw two pending cases were actually passed, and the left one was unstoppable... Thanks!

@LLee233 LLee233 force-pushed the support_int64_array branch from 67169c0 to 122d5d9 Compare May 23, 2024 09:01
From00
From00 approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyu-intel xinyu-intel merged commit bf537bc into PaddlePaddle:develop May 27, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@From00 From00 From00 approved these changes

@xinyu-intel xinyu-intel xinyu-intel approved these changes

@wanghuancoder wanghuancoder wanghuancoder left review comments

Assignees

@vivienfanghuagood vivienfanghuagood

Labels
contributor External developers Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LLee233 @From00 @xinyu-intel @wanghuancoder @vivienfanghuagood