[Prim][PIR] support huber_loss op forward in prim pir #64425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
| auto ans = where<T>(abs_val <= delta_full, | ||
| 0.5 * val * val, | ||
| delta_full * (abs_val - 0.5 * delta_full)); | ||
| return std::make_tuple(cast<T>(ans, input.dtype()), |
There was a problem hiding this comment.
适配一下动态shape，以及这里确认一下，cast是否必须？
cyber-pioneer
approved these changes
May 21, 2024
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Others
PR Types
Others
Description
[Prim][PIR] support huber_loss op forward in prim pir
huber_loss is a sub op for smooth_l1_loss，so it's also support smooth_l1_loss prim pir forward