Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th No.53】move fake_channel_wise_quantize_abs_max/fake_channel_wise_quantize_dequantize_abs_max op to phi - part #64266

Merged
merged 4 commits into from
May 16, 2024

Conversation

NKNaN
Copy link
Contributor

@NKNaN NKNaN commented May 13, 2024

PR Category

Others

PR Types

Others

Description

combine #63991 with #64255

Copy link

paddle-bot bot commented May 13, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label May 13, 2024
Comment on lines 355 to 364
) = _C_ops.fake_channel_wise_quantize_dequantize_abs_max(
input,
self._quant_bits,
1,
self._quant_axis,
quant_out,
out_scale,
)
return out

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里这样改一下:

            (
                out,
                scale,
            ) = _C_ops.fake_channel_wise_quantize_dequantize_abs_max(
                input,
                self._quant_bits,
                1,
                self._quant_axis
            )
            _C_ops.assign_out_(out, quant_out)
            _C_ops.assign_out_(scale, out_scale)
            return quant_out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 57c7b0d into PaddlePaddle:develop May 16, 2024
31 checks passed
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 18, 2024
…nnel_wise_quantize_dequantize_abs_max op to phi - part (PaddlePaddle#64266)

* move fake_channel_wise_quantize_abs_max and fake_channel_wise_quantize_dequantize_abs_max to phi

* fix opps yaml

* fix ops yaml

* fix accuracy
YuanRisheng pushed a commit to YuanRisheng/Paddle that referenced this pull request May 21, 2024
…nnel_wise_quantize_dequantize_abs_max op to phi - part (PaddlePaddle#64266)

* move fake_channel_wise_quantize_abs_max and fake_channel_wise_quantize_dequantize_abs_max to phi

* fix opps yaml

* fix ops yaml

* fix accuracy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants