[XPU] avoid malloc redundant memory when creating context in comm man… #64139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lj970926
reviewed
May 10, 2024
| @@ -38,7 +38,8 @@ class XPUContext : public DeviceContext, | |||
| public: | |||
| XPUContext(); | |||
| @@ -38,7 +38,8 @@ class XPUContext : public DeviceContext, | |||
| public: | |||
| XPUContext(); | |||
|
|
|||
| explicit XPUContext(const XPUPlace&); | |||
| // is_comm_context = 1 for init comm context with gm_size=1 and l3_size=1 | |||
| explicit XPUContext(const XPUPlace&, bool is_comm_context = 0); | |||
There was a problem hiding this comment.
这里为啥默认值不直接置为false而要用int类型0呢？
| @@ -211,8 +211,9 @@ void CommContextManager::CreateBKCLCommContext( | |||
| std::make_unique<BKCLCommContext>(rank, size, bkcl_id); | |||
|
|
|||
| if (CommContextManager::device_id != -1) { | |||
| std::unique_ptr<phi::XPUContext> dev_ctx( | |||
| new phi::XPUContext(phi::XPUPlace(CommContextManager::device_id))); | |||
| bool is_comm_context = 1; | |||
There was a problem hiding this comment.
同上，另外感觉这个变量只是作为参数传进构造函数好像没啥必要
|
可以先这么绕开，回头我看看是不是直接把dev_ctx拿掉。 |
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 10, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 11, 2024
update: 不太容易拿掉，unified_comm下有个地方需要取这个ctx，为了后续修改方便还是和gpu保持一致 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Communication Library
PR Types
Bug fixes
Description
fix the redundant malloc caused my XPUAPI_DEFAULT_SIZE when creating context in comm manager.
related PR: #63817