Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove templatedoc decorator #63769

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Apr 23, 2024

PR Category

Others

PR Types

Others

Description

ref #63734
remove templatedoc decorator
清理掉 templatedoc 函数定义

python\paddle\base\layers\layer_function_generator.py 里的 autodoc 没有使用应该可以删除

@SigureMo

Copy link

paddle-bot bot commented Apr 23, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 23, 2024
@SigureMo
Copy link
Member

基于一个前提,PIR 不会再使用 OpProto,所以任何使用 OpProto 生成 doc 的地方都应该尽可能清理

@SigureMo
Copy link
Member

另外,python/paddle/base/layers/layer_function_generator.py 还有调用方吗?能直接全删掉吗

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Apr 23, 2024
@ooooo-create
Copy link
Contributor Author

另外,python/paddle/base/layers/layer_function_generator.py 还有调用方吗?能直接全删掉吗

没有函数的调用方,可以直接删了这个文件~,python\paddle\base\layers\math_op_patch.py 引入的 OpProtoHolder 可以修改引用路径

@SigureMo
Copy link
Member

#63754 已合入,可以 merge 下了

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit 5673457 into PaddlePaddle:develop Apr 24, 2024
28 of 29 checks passed
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Apr 25, 2024
@ooooo-create ooooo-create deleted the clean/templatedoc_part2 branch March 8, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants