add illustration for reshape API #63365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the indefinite article
… my-branch add illustration for the reshape API && fix grammatical mistakes of the indefinite article
|
你的PR提交成功，感谢你对开源项目的贡献! |
python/paddle/tensor/manipulation.py
Outdated
| @@ -4345,11 +4345,15 @@ def reshape(x, shape, name=None): | |||
|
|
|||
| - 3. Given a 3-D tensor x with a shape [2, 4, 6], and the target shape is [-1, 0, 3, 2], the reshape operator will transform x into a 4-D tensor with shape [2, 4, 3, 2] and leaving x's data unchanged. In this case, besides -1, 0 means the actual dimension value is going to be copied from the corresponding dimension of x. | |||
|
|
|||
| The following figure illustrates the first example -- a 3D tensor of shape [2, 4, 6] is transformed into a 2D tensor of shape [6, 8], during which the order and values of the elements in the tensor remain unchanged. The elements in the two subdiagrams correspond to each other, clearly demonstrating how the reshape API works. | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
这边不要用 markdown 格式的图片引用，否则无法渲染，可以看预览。和中文（ PaddlePaddle/docs#6569 ）一致即可，但引用路径需要改一下，因为仓库换了（docs -> Paddle)。
因为英文文档是通过抽取源码里的docstring，生产.rst 文件，所以和中文一样，得符合 sphinx 语法。
python/paddle/tensor/manipulation.py
Outdated
| Args: | ||
| x (Tensor): An N-D Tensor. The data type is ``float16``, ``float32``, ``float64``, ``int16``, ``int32``, ``int64``, ``int8``, ``uint8``, ``complex64``, ``complex128``, ``bfloat16`` or ``bool``. | ||
| x (Tensor): A N-D Tensor. The data type is ``float16``, ``float32``, ``float64``, ``int16``, ``int32``, ``int64``, ``int8``, ``uint8``, ``complex64``, ``complex128``, ``bfloat16`` or ``bool``. |
There was a problem hiding this comment.
很细心，但 N-D Tensor 的发音以元音音素开始（即 N "en" 的发音），因此前面应该使用 an，1-D Tensor也同理（"one"的发音开始）
不过 Tensor 前面确实是跟着 a
… my-branch add illustration for reshape API
… my-branch add illustration for reshape API
runzhech
pushed a commit
to runzhech/Paddle
that referenced
this pull request
Apr 30, 2024
* feat:add illustration for reshape API && fix:grammatical mistakes of the indefinite article * bug fixes * add illustration for reshape API * Update python/paddle/tensor/manipulation.py * add illustration for reshape API * Update python/paddle/tensor/manipulation.py --------- Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>
runzhech
pushed a commit
to runzhech/Paddle
that referenced
this pull request
Apr 30, 2024
* feat:add illustration for reshape API && fix:grammatical mistakes of the indefinite article * bug fixes * add illustration for reshape API * Update python/paddle/tensor/manipulation.py * add illustration for reshape API * Update python/paddle/tensor/manipulation.py --------- Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Docs
Description
对应的中文文档修复为：PaddlePaddle/docs#6569