[DCU] fix bugs and surpport some fused ops #63217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
qili93
reviewed
Apr 7, 2024
| @@ -35,7 +35,11 @@ struct GeluFunctor { | |||
| template <typename T> | |||
| struct FastGeluFunctor { | |||
| inline __device__ T operator()(const T x) const { | |||
| #ifdef PADDLE_WITH_HIP | |||
| PADDLE_ENFORCE(0, "FastGelu not surpport for rocm"); | |||
There was a problem hiding this comment.
CI这里提示错误，建议修改为
PADDLE_THROW(phi::errors::Unimplemented("ROCM does not support FastGelu"));
raindrops2sea
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Custom Device
PR Types
Bug fixes
Description
重新支持dcu complex64/128
dcu支持fused_bias_residual_layernorm op
dcu支持fused_bias_dropout_residual_layer_norm前反向op
dcu支持rms_norm前反向op
解决depthwise conv grad op bug【https://github.com/PaddlePaddle/Paddle/issues/60500】
解决 hip graph test bugs ，已知问题：需要 export HIP_GRAPH_LARGE_LAUNCH=0
相关test均通过