[OneDNN][PIR] Add depthwise_conv_onednn_pass #63051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhanglirong1999
force-pushed
the
pir_depthwise_conv_pass
branch
from
787c75b to
0e1c434
Compare
zhanglirong1999
changed the title
zhanglirong1999
force-pushed
the
pir_depthwise_conv_pass
branch
7 times, most recently
from
512a708 to
a559af7
Compare
|
这个op不支持python测的test case，只能用c++实现。但win32下test case编译会不过，且py3的CI中似乎并没有默认开启MKLDNN，导致链接会有问题，因此暂时在Make file中过滤了win32 |
zhanglirong1999
force-pushed
the
pir_depthwise_conv_pass
branch
from
a559af7 to
92813b1
Compare
yuanlehome
reviewed
Apr 2, 2024
|
|
||
| } // namespace pir | ||
|
|
||
| REGISTER_IR_PASS(depthwise_conv_mkldnn_pass, DepthwiseConvMKLDNNPass); |
There was a problem hiding this comment.
pass命名中的mkldnn和onednn是否可以统一成onednn？
yuanlehome
reviewed
Apr 2, 2024
| @@ -0,0 +1,69 @@ | |||
| // Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
使用这种方式写单测的原因是，组网时没法组出depthwise_conv算子吗？
There was a problem hiding this comment.
是的，python 端没有depthwise_conv的api支持，现有pir的test case架构应该暂时不支持这种，只能走c++侧
There was a problem hiding this comment.
看代码逻辑，应该是需要满足一定的条件，才能组出depthwise_conv2d算子，是否可以尝试一下？
zhanglirong1999
force-pushed
the
pir_depthwise_conv_pass
branch
3 times, most recently
from
32906b2 to
f5ebb8f
Compare
yuanlehome
reviewed
Apr 3, 2024
test/ir/pir/fused_pass/onednn/test_depthwise_conv_onednn_pass.py
Outdated
Show resolved
Hide resolved
zhanglirong1999
force-pushed
the
pir_depthwise_conv_pass
branch
2 times, most recently
from
b122afb to
2597663
Compare
yuanlehome
previously approved these changes
Apr 8, 2024
yuanlehome
changed the title
yuanlehome
approved these changes
Apr 9, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Apr 9, 2024
* first commit of depthwise conv pass * style fix * add copy_onnx * add other create to test * check if onednn pass not register * add ifdef PADDLE_WITH_DNNL * add WITH_MKLDNN * fix style bug * add PADDLE_WITH_DNNL * add condition in onnx * SKIP WIN32 CI * name change mkl to onednn * change name * use python ut for depthwise conv * delete skipif * Rename test_depthwise_conv_onednn_pass.py to test_pir_depthwise_conv_onednn_pass.py
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Apr 10, 2024
* first commit of depthwise conv pass * style fix * add copy_onnx * add other create to test * check if onednn pass not register * add ifdef PADDLE_WITH_DNNL * add WITH_MKLDNN * fix style bug * add PADDLE_WITH_DNNL * add condition in onnx * SKIP WIN32 CI * name change mkl to onednn * change name * use python ut for depthwise conv * delete skipif * Rename test_depthwise_conv_onednn_pass.py to test_pir_depthwise_conv_onednn_pass.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Others
PR Types
New features
Description
We rewrite depthwise_conv_onednn_pass for PIR.