Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CINN] Support injective group fusion #61197

Merged
merged 10 commits into from
Jan 30, 2024
Merged

Conversation

zyfncg
Copy link
Contributor

@zyfncg zyfncg commented Jan 26, 2024

PR types

Others

PR changes

Others

Description

Pcard-73448

RoPE子图静态shape下在前端支持将gather_nd、slice与concat算子融合到一个group中。
image

测试脚本:
FLAGS_cinn_convert_static_dim_to_dynamic_dim=2048:S0 FLAGS_cinn_bucket_compile=True ctest -R test_rope -V

// vertical relation: 1.can compute inline
if (producer->result(0).use_count() == 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是能融合slice/concat的tricky代码吗?

Copy link
Contributor Author

@zyfncg zyfncg Jan 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,这里的判断不算很tricky,如果融合规则明确的话,后面是可以直接使用的

@@ -668,7 +672,7 @@ GroupList OpFusionPassInternal(
ss << "\n";
}
}
VLOG(6) << ss.str();
VLOG(1) << ss.str();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VLOG mismatch?

Copy link
Contributor Author

@zyfncg zyfncg Jan 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for debug, will change back before merging

@zyfncg zyfncg changed the title [CINN Test] Support injective group fusion [CINN] Support injective group fusion Jan 28, 2024
tc20042008
tc20042008 previously approved these changes Jan 28, 2024
Copy link
Contributor

@jiahy0825 jiahy0825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BiynXu BiynXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyfncg zyfncg merged commit 79f3b1c into PaddlePaddle:develop Jan 30, 2024
29 of 30 checks passed
@zyfncg zyfncg deleted the inject_op_merge branch January 30, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants