Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR] Replace OpResult with Value in python #60798

Merged
merged 7 commits into from
Jan 19, 2024
Merged

[PIR] Replace OpResult with Value in python #60798

merged 7 commits into from
Jan 19, 2024

Conversation

huangjiyi
Copy link
Member

@huangjiyi huangjiyi commented Jan 15, 2024 •
edited
Loading

PR types

Others

PR changes

Others

Description

Done

  • 将 Paddle/python 目录下的 OpResult 用法（含注释和变量名）替换为 Value

Todo

  • 移除绑定到 python 的 OpResult，需要将所有返回值为 OpResult 并且绑定到 python 的函数的返回值替换为 Value

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jan 15, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jan 15, 2024
@huangjiyi huangjiyi force-pushed the replace_opresult_with_value branch from 1199163 to 51f712e Compare January 15, 2024 12:40
wanghuancoder
wanghuancoder approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

winter-wang
winter-wang approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xiaoguoguo626807
xiaoguoguo626807 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winter-wang winter-wang merged commit f335680 into PaddlePaddle:develop Jan 19, 2024
@huangjiyi huangjiyi mentioned this pull request Jan 19, 2024
Closed
@xysheng-baidu
Copy link
Contributor

image 这个问题跟该pr 相关，有修复计划吗？

@huangjiyi
Copy link
Member Author

image 这个问题跟该pr 相关，有修复计划吗？

@xysheng-baidu 是哪个 CI 报的错，我可以现在修一下

@xysheng-baidu
Copy link
Contributor

image 这个问题跟该pr 相关，有修复计划吗？

@xysheng-baidu 是哪个 CI 报的错，我可以现在修一下

是PaddleCustomDevice库报的错：PaddlePaddle/PaddleCustomDevice#909 ，该库的CI是基于paddle nightly环境。

@huangjiyi
Copy link
Member Author

image
@xysheng-baidu , 我看 Paddle 目前的代码已经和图里报错的代码不一样了，是不是 PaddleCustomDevice 没有拉取到最新的代码

@xysheng-baidu
Copy link
Contributor

image @xysheng-baidu , 我看 Paddle 目前的代码已经和图里报错的代码不一样了，是不是 PaddleCustomDevice 没有拉取到最新的代码

paddle nightly包可能会有延迟，我更想下最新包试试，感谢。

@huangjiyi huangjiyi deleted the replace_opresult_with_value branch March 8, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@winter-wang winter-wang winter-wang approved these changes

@xiaoguoguo626807 xiaoguoguo626807 xiaoguoguo626807 approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@huangjiyi @xysheng-baidu @wanghuancoder @XiaoguangHu01 @winter-wang @xiaoguoguo626807