[PIR][CUSTOM PASS] Part1: Reconstruct drr #60783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
yuanlehome
changed the title
yuanlehome
force-pushed
the
reconstruct_drr
branch
from
6acc76a to
fe3aae1
Compare
zyfncg
reviewed
Jan 15, 2024
Comment on lines
42
to
45
| virtual std::string pattern_name() const = 0; | ||
|
|
||
| // Give the drr pattern benefit. | ||
| virtual uint32_t pattern_benefit() const { return 1; } |
There was a problem hiding this comment.
讨论后，将pattern_name()改为name(), pattern_benefit()改为benefit()，更加直观简洁
yuanlehome
changed the title
zyfncg
approved these changes
Jan 16, 2024
vivienfanghuagood
approved these changes
Jan 16, 2024
raindrops2sea
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
为了支持外部用户使用C++写自定义Pass，需要为Pir/Drr等梳理规范include头文件。作为Part1，本PR将Drr重构了一下，规范出include文件夹。修改主要是如下几点：
修改前Drr目录：
修改后Drr目录：
Others
Pcard-71500