【PIR OpTest Fix No.39】 fix test_c_reduce_min_translate #60236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
kangguangli
reviewed
Dec 22, 2023
kangguangli
reviewed
Dec 25, 2023
Comment on lines
26
to
38
| def build_model(self): | ||
| with paddle.static.scope_guard(self.new_scope): | ||
| with paddle.static.program_guard(self.main_program): | ||
| x = paddle.ones(shape=(100, 2, 3), dtype='float32') | ||
| y = paddle.ones(shape=(100, 2, 3), dtype='float32') | ||
| attrs = {'ring_id': 0, 'root_id': 0, 'use_calc_stream': False} | ||
| helper = LayerHelper('c_reduce_min') | ||
| helper.append_op( | ||
| type="c_reduce_min", | ||
| inputs={"X": x}, | ||
| outputs={"Out": y}, | ||
| attrs=attrs, | ||
| ) |
There was a problem hiding this comment.
感觉这里还可以优化下，是不是只要这样写下就可以了？
Suggested change
| def build_model(self): | |
| with paddle.static.scope_guard(self.new_scope): | |
| with paddle.static.program_guard(self.main_program): | |
| x = paddle.ones(shape=(100, 2, 3), dtype='float32') | |
| y = paddle.ones(shape=(100, 2, 3), dtype='float32') | |
| attrs = {'ring_id': 0, 'root_id': 0, 'use_calc_stream': False} | |
| helper = LayerHelper('c_reduce_min') | |
| helper.append_op( | |
| type="c_reduce_min", | |
| inputs={"X": x}, | |
| outputs={"Out": y}, | |
| attrs=attrs, | |
| ) | |
| self.inputs = {} | |
| self.outputs = {} | |
| self.attrs = {} |
kangguangli
reviewed
Dec 25, 2023
kangguangli
approved these changes
Dec 28, 2023
heavyrain-lzy
approved these changes
Dec 28, 2023
|
目录名/translator/ translator 使用名称不同不一致 |
好的 我提个PR修改以下 |
Wanglongzhi2001
pushed a commit
to Wanglongzhi2001/Paddle
that referenced
this pull request
Jan 7, 2024
…60236) * add test_c_reduce_min_translate * fix * fix * fix * fix * fix * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
添加
test_c_reduce_min_translate验证c_reduce_min可以被正常翻译