[XPU][Phi Kernel] nonzero kernel support simulator XPUSIM_SKIP_RUN mode #60224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
dynamicheart
force-pushed
the
xpu_nonzero_simulator_skip_run_mode
branch
from
3f1e56b to
ad55026
Compare
dynamicheart
commented
Dec 21, 2023
| @@ -40,6 +42,13 @@ void NonZeroKernel(const Context& dev_ctx, | |||
| dev_ctx.GetPlace(), | |||
| static_cast<void*>(true_num), | |||
| sizeof(int32_t)); | |||
| if (std::getenv("XPU_SIMULATOR_MODE") && std::getenv("XPUSIM_SKIP_RUN") && | |||
There was a problem hiding this comment.
备注：驱动里面仅判断std::getenv("XPU_SIMULATOR_MODE")，模拟器将XPUSIM_SKIP_RUN的值转成bool来进行判断。
houj04
reviewed
Dec 21, 2023
加了几个单测，由于CI环境里面要测到新增代码里面分支，因此要把 |
dynamicheart
force-pushed
the
xpu_nonzero_simulator_skip_run_mode
branch
from
161be2f to
dd77073
Compare
houj04
approved these changes
Dec 22, 2023
Wanglongzhi2001
pushed a commit
to Wanglongzhi2001/Paddle
that referenced
this pull request
Jan 7, 2024
…de (PaddlePaddle#60224) * [XPU][Phi Kernel] nonzero kernel support simulator XPUSIM_SKIP_RUN mode * [XPU][Phi Kernel] add unittest for nonzero simulator skip_run mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Description
nonzero kernel support simulator XPUSIM_SKIP_RUN mode.
In the simulator mode, the variable
true_num_cpustores an uninitialized value. To avoid allocating a memory of random size, we assignnumelto it.