Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【bugfix】fix and remove topo order effect #59996

Merged
merged 1 commit into from
Dec 15, 2023
Merged

【bugfix】fix and remove topo order effect #59996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/paddle/base/backward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,8 @@ def _addup_repetitive_outputs_(
var_device = collections.defaultdict(str)

def _change_order_by_topo_order(var_name):
if topo_order_for_backward is None:
return
origin_names = renamed_vars[var_name]
origin_names.sort(key=lambda x: topo_order_for_grad_name[x])

Expand Down Expand Up @@ -1596,12 +1598,12 @@ def find_op_index(block_desc, cur_op_desc):
program._appending_grad_times
]
# sum parameter's gradients' var given multiple var gradient
topo_order = _topo_order_map(block, target_vars)
if os.environ.get("FLAGS_program_topo_reorder", "False") in [
'True',
'1',
'true',
]:
topo_order = _topo_order_map(block, target_vars)
topo_order_for_backward = _topo_bwd_order_map(
topo_order, get_backward_op_desc
)
Expand Down