[Semi-Auto] Replace the pointers in reshape-like spmd rule with smart pointers. #59101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
deepllz
reviewed
Nov 20, 2023
|
|
||
| void Split::set_input(DimTrans* dim) { input_dim_trans_ = dim; } | ||
| void Split::set_input(const std::shared_ptr<DimTrans>& dim) { |
There was a problem hiding this comment.
shared_ptr类型的参数，是否有必要使用引用，一般建议使用值传参即可。
| const std::set<int64_t>& sharded_input_dims) { | ||
| std::shared_ptr<DimTrans> GetDimTrans( | ||
| const std::shared_ptr<DimTrans>& dim_trans, | ||
| std::vector<std::vector<bool>>* shardable, |
There was a problem hiding this comment.
参数顺序：这里是否考虑把输出参数放到输入参数的后面？
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
… pointers. (PaddlePaddle#59101) * use smart pointer in reshape-like spmd rules * remove ununsed code and comments * replace the reference of shared_ptr in function arg list * modify the arg order in GetDimTrans function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-76459
Replace the pointers in reshape-like spmd rule with smart pointers.