[clang-tidy] NO.6 enable modernize-avoid-c-arrays step: 2
#55954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
…l/Paddle into c_t_avoid_c_arrays # Conflicts: # .clang-tidy
…rrays # Conflicts: # paddle/fluid/pybind/eager_py_layer.cc
|
@GreatV 求助 windows ci 报错 |
|
@gouzil |
没超时呀, PR-CI-Windows-OPENBLAS error C2679: binary '==': no operator found which takes a right-hand operand of type 'const T2' (or there is no acceptable conversion) |
GreatV
reviewed
Aug 6, 2023
paddle/utils/span_test.cc
Outdated
| CHECK_EQ(s.data(), arr); | ||
| CHECK_EQ(s.begin(), std::begin(arr)); | ||
| CHECK_EQ(s.end(), std::end(arr)); | ||
| CHECK_EQ(s.data(), arr.data()); |
There was a problem hiding this comment.
感觉像paddle::span的问题, 这个CHECK_EQ在paddle/utils/array_ref_test.cc下没有问题，可以暂时考虑先nolint
luotao1
added
HappyOpenSource Pro
zhangbo9674
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
所有的
modernize-avoid-c-arrays检查将会在此pr做完相关链接:
modernize-avoid-c-arrayscheck #55774