Refine evaluator op types #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
reviewed
Oct 30, 2017
paddle/operators/accuracy_op.cc
Outdated
| PADDLE_ENFORCE(ctx->HasInput("Label"), | ||
| "Input(Label) of AccuracyOp should not be null."); | ||
| "Input(Label) of accuracy op should not be null."); |
paddle/operators/accuracy_op.cc
Outdated
| auto label_dim = ctx->GetInputDim("Label"); | ||
| // assume indices has same shape with infernece, because |
paddle/operators/accuracy_op.cc
Outdated
| PADDLE_ENFORCE_EQ(inference_dim[0], label_dim[0], | ||
| "inference size must be the same as label size"); | ||
| "inference height must be the same as label."); |
There was a problem hiding this comment.
什么是inference height？是想说“推测出来的高度“吗？如果是，应该是 inferred height.
paddle/operators/accuracy_op.cc
Outdated
| PADDLE_ENFORCE_EQ(inference_dim[0], label_dim[0], | ||
| "inference size must be the same as label size"); | ||
| "inference height must be the same as label."); |
There was a problem hiding this comment.
另外，height 是什么意思呢？如果是说matrix的大小，那么有num_rows, num_columns之说。
There was a problem hiding this comment.
嗯嗯，是matrix的大小。以上Comment都已更新，感谢review！
zchen0211
pushed a commit
to zchen0211/Paddle
that referenced
this pull request
Oct 31, 2017
* refine evaluator op types * update * follow comments * update * fix v2 mnist case * fix v2 mnist case * update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update and refine
accuracyandaucop.