Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way to set attributes for grad op maker #44514

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Change the way to set attributes for grad op maker #44514

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97ca78f
fix typos in template for codegen of operators
Jul 15, 2022
64913cf
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
Jul 21, 2022
50d0dcb
change the way to set attributes for grad op maker
Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paddle/phi/api/yaml/generator/templates/operator_utils.c.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ class {{name | to_pascal_case}}OpMaker : public framework::SingleGradOpMaker<T>
forward_output_orig_names)}});
{% endfor %}

grad_op->SetAttrMap(this->Attrs());
{% for attr in api["attrs"] %}
{% set attr_name = attr["name"] %}
{% if attr_name in forward_attr_names %}
Expand All @@ -342,7 +343,6 @@ class {{name | to_pascal_case}}OpMaker : public framework::SingleGradOpMaker<T>
{% elif attr["typename"] == "Scalar" %}
grad_op->SetInput("{{attr_name | to_pascal_case}}Tensor", this->Input("{{attr_name | to_pascal_case}}Tensor"));
{% endif %}
grad_op->SetAttr("{{attr_name}}", this->GetAttr("{{forward_attr_orig_names[forward_attr_names.index(attr_name)]}}"));
{% else %}{# maybe something wrong: backward op has more attrs than the forward one#}
grad_op->AddAttr<{{attr["typename"] | to_op_attr_type}}>({{attr_name}}, "({{attr["typename"] | to_op_attr_type}}), exceptional attr {{attr_name}}");
grad_op->SetAttr("{{attr_name}}", {{process_default_value(attr)}});
Expand Down