Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine the slice Op #24967

Merged
merged 5 commits into from
Jun 10, 2020
Merged

refine the slice Op #24967

merged 5 commits into from
Jun 10, 2020

Conversation

wangchaochaohu
Copy link
Contributor

@wangchaochaohu wangchaochaohu commented Jun 8, 2020 •
edited
Loading

PR types

Performance optimization

PR changes

OPs

Describe

xlnet performace fp16 training improve about 10%

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 8, 2020

Thanks for your contribution!
Please add test = develop in your commit message to trigger CI to ensure your PR can be merged.
See Paddle CI Manual for details.

1 similar comment
@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 8, 2020

Thanks for your contribution!
Please add test = develop in your commit message to trigger CI to ensure your PR can be merged.
See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 8, 2020

❌This PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

1 similar comment
@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 8, 2020

❌This PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@wangchaochaohu wangchaochaohu changed the title refine the slice Op test=develo refine the slice Op Jun 8, 2020
@wangchaochaohu wangchaochaohu requested review from liym27 and kuke June 8, 2020 11:37
@dingsiyu
Copy link
Contributor

dingsiyu commented Jun 9, 2020 •
edited
Loading

xlnet训练速度：
fp16:
优化前：1.52 step/s
优化后：1.7 step/s

kuke
kuke approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangchaochaohu wangchaochaohu merged commit 613303d into PaddlePaddle:develop Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuke kuke kuke approved these changes

@liym27 liym27 Awaiting requested review from liym27

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangchaochaohu @dingsiyu @kuke