[adc] Refactor ADS1115 driver #24428
Open
+103
−194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Two main problems:
The driver code is also a bit too optimistic and doesn't log any comms errors.
Solution
I've refactored the driver to be more robust.
Also added perf counter to track comms errors.
Changelog Entry
For release notes:
Alternatives
Burn the I2C garbage.
Test coverage
Tested in hardware by shorting the I2C pins to induce comms failures. Driver recovers and doesn't spam the console.