Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RSSI in dBm and LQ to GHST #24351

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Conversation

tonycake
Copy link
Contributor

Extend the GHST driver to provide RSSI in dBm and LQ using the mechanism recently added to other PX4 RC drivers.
These values were already provided in the GHST telemetry stream, but only the (limited value) RSSI in % was previously available.

@dagar
Copy link
Member

dagar commented Feb 18, 2025

Did you see the CI build and format failures?

@tonycake
Copy link
Contributor Author

Did you see the CI build and format failures?

Yes... n00b mistake :-(

@tonycake tonycake force-pushed the ghstrssidbm branch 2 times, most recently from 50b859e to a17112c Compare February 19, 2025 08:37
@tonycake
Copy link
Contributor Author

Did you see the CI build and format failures?

Fixed the formatting, and squashed the commits. Flash error during CI is a little confusing, any advice?

@mrpollo
Copy link
Contributor

mrpollo commented Feb 21, 2025

@tonycake can you please rebase your branch with the latest from upstream main? we pushed a fix that should take care of the failing CI test

@tonycake
Copy link
Contributor Author

@tonycake can you please rebase your branch with the latest from upstream main? we pushed a fix that should take care of the failing CI test

Wondering how to get this PR merged. The check related to flash usage is not exactly clear, and seems to indicate a problem unrelated to my change.
Any advice would be great.

@dakejahl
Copy link
Contributor

@tonycake rebase again and it will pass. We've disabled that check since.

@dakejahl dakejahl merged commit ba31054 into PX4:main Feb 28, 2025
59 checks passed
@tonycake tonycake deleted the ghstrssidbm branch February 28, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants