Simplify Battery-related Enum Naming #24265
Open
+101
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdomoszlai13
force-pushed
the
rename-batt-enums
branch
from
f6298af to
8a3e55b
Compare
MaEtUgR
reviewed
Jan 29, 2025
sdomoszlai13
force-pushed
the
rename-batt-enums
branch
5 times, most recently
from
f630655 to
9106bf6
Compare
MaEtUgR
previously approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Thanks for making the enum naming more sensible 👍
I increased the version number of the message battery_status since it's now versioned and this is the first change to the message since that was done. I'm not sure if there's any compatibility issue when changing messages before #24113 @bkueng could you clarify?
This is just a warm up to splitting up the message in #24111
bkueng
reviewed
Feb 28, 2025
msg/versioned/BatteryStatus.msg
Outdated
| @@ -1,4 +1,4 @@ | |||
| uint32 MESSAGE_VERSION = 0 | |||
| uint32 MESSAGE_VERSION = 1 | |||
There was a problem hiding this comment.
If you only change constants you don't need to increase the version
sdomoszlai13
force-pushed
the
rename-batt-enums
branch
from
1899b90 to
c440b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The battery-related enums (source and state) contain a leading 'BATTERY_' string in the enums's member names. The naming should to be clear enough without that string.
Solution
Remove the leading 'BATTERY_' string in the enums's member names.
Changelog Entry
For release notes:
Simplified battery-related enum naming