Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected error while building with PCRE2GREP_SUPPORT_JIT turned off and targeting 10.15 #109

Closed
siegel opened this issue Apr 21, 2022 · 2 comments

Comments

@siegel
Copy link

siegel commented Apr 21, 2022

Steps:

  1. ccmake .
  2. Change CMAKE_OSX_DEPLOYMENT_TARGET to 10.15.
  3. Change PCRE2GREP_SUPPORT_JIT to OFF.
  4. press c to configure, then g to generate, then exit ccmake.
  5. make clean; make

Expected:
-> successful build

Actual:
-> build fails, with error:

In file included from /Users/siegel/git/pcre2/src/sljit/sljitLir.c:275:
/Users/siegel/git/pcre2/src/sljit/sljitExecAllocator.c:156:2: error: "Must target Big Sur or newer"

It would appear that even when JIT is turned off, the sljit internals are getting compiled anyway. (I can't currently require macOS 11.0, which means that I can't currently enable JIT for all architectures. I suspect that the current state of affairs is related to bug #2769 in the old tracker which appears to have never been resolved.)

@carenas
Copy link
Contributor

carenas commented Apr 21, 2022

It would appear that even when JIT is turned off

To disable JIT you need to set the PCRE2_SUPPORT_JIT variable, the variable you changed disabled JIT only as part of the pcre2grep tool.

carenas added a commit to carenas/sljit that referenced this issue Apr 22, 2022
While building for macOS older than 11 in Apple Silicon makes no
sense, some build systems lack the flexibility to set a target per
architecture while aiming to support multi architecture binaries.

Allow an option in those cases by using the slower runtime checks
if the toolchain allows it.

Fixes: PCRE2Project/pcre2#109
@PhilipHazel
Copy link
Collaborator

I'm closing this as dealt with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants