Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix just default recipe invocation #510

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix just default recipe invocation #510

merged 1 commit into from
Oct 29, 2024

Conversation

AetherUnbound
Copy link
Collaborator

Description of Changes

Newer versions of just allow the --list option (-l) to specify arguments after it. This is a breaking change for us, as now the --unsorted argument (-u) immediately following it is misread as a submodule. This PR fixes this issue by rearranging the arguments for the default recipe.

Testing instructions

Check out the main branch, and run just in the repo. You should see the following:

$ just
error: Justfile does not contain submodule `u`

Then check out this branch and run just. You should see all the recipes listed instead.

Checks

  • I have rebased my changes on main

  • just lint passes

  • just test passes

@AetherUnbound AetherUnbound added bug Something isn't working docker/env Docker, environment, or CI changes labels Oct 28, 2024
@AetherUnbound AetherUnbound requested a review from a team as a code owner October 28, 2024 22:58
@sea-kelp
Copy link
Collaborator

Rebased changes onto main branch

Copy link
Collaborator

@sea-kelp sea-kelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me!

@sea-kelp sea-kelp merged commit 29520a5 into main Oct 29, 2024
2 checks passed
@sea-kelp sea-kelp deleted the fix/just-default branch October 29, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docker/env Docker, environment, or CI changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants