Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build workflow with correct default branch #3

Merged
merged 1 commit into from
May 27, 2021

Conversation

bjfish25
Copy link
Contributor

Proposed changes

Update build workflow with correct default branch. Build workflow doesn't reference default master branch.

Issues for these changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers

Relevant Links

Further comments

@bjfish25 bjfish25 requested a review from shubydo May 27, 2021 14:24
@CLAassistant

This comment has been minimized.

@bjfish25 bjfish25 force-pushed the bug-fix/update-main-references branch from a305622 to a74fe96 Compare May 27, 2021 14:25
@github-actions

This comment has been minimized.

@@ -3,9 +3,11 @@ on:
push:
branches:
- main
- master
Copy link
Collaborator

@shubydo shubydo May 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Another option is to change the default branch from master to main.

@bjfish25 bjfish25 merged commit fda5d8e into master May 27, 2021
@bjfish25 bjfish25 deleted the bug-fix/update-main-references branch May 27, 2021 14:40
@github-actions
Copy link

Unit Test Results

    2 files      2 suites   10s ⏱️
249 tests 249 ✔️ 0 💤 0 ❌

Results for commit fda5d8e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants