Region filtering for health notifications #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
shubydo
reviewed
Aug 9, 2021
Comment on lines
+230
to
+231
| healthCmd.PersistentFlags().StringVar(&healthExcludeRegions, "exclude-regions", "", "Set of regions separated by [,] to exclude Health Notifications from. Takes precedence over include-regions") | ||
| healthCmd.PersistentFlags().StringVar(&healthIncludeRegions, "include-regions", "", "Set of regions separated by [,] to include Health Notifications from. Use \"global\" as a region if wanting notifications affecting all regions. Ignored when exclude-regions is set") |
There was a problem hiding this comment.
If neither include-regions or exclude-regions is specified, will results be returned for every region?
shubydo
approved these changes
Aug 9, 2021
rajholla
reviewed
Aug 10, 2021
| @@ -1,3 +1,8 @@ | |||
| ## v0.1.2 ( 9 August 2021) | |||
There was a problem hiding this comment.
new feature - v0.2.0, even otherwise v.0.1.3
|
nicely done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
It is possible for AWS to generate notifications that are unwanted / uncared about as they involve a region not currently in use. Thus we would like a way to filter these out from use.
Issues for these changes
Types of changes
Checklist
README.md,CHANGELOG.md, etc. - if appropriate)Dependencies and Blockers
Relevant Links
Further comments