Code

Add AccessControlDefaultAdminRules#4009

Code

Merged

frangio merged 78 commits intoOpenZeppelin:masterOpenZeppelin/openzeppelin-contracts:masterfrom ernestognw:lib-618-accesscontrol-admin-rulesernestognw/openzeppelin-contracts:lib-618-accesscontrol-admin-rulesCopy head branch name to clipboardFeb 24, 2023

+666-10

Commits

Commits on Jan 27, 2023

• Create AccessControlAdminRules and its corresponding interface

  ernestognw

  committed
  3989054

  Copy full SHA for 3989054

Commits on Jan 28, 2023

• Add tests

  ernestognw

  committed
  da52678

  Copy full SHA for da52678

• Add changeset

  ernestognw

  committed
  f7738a6

  Copy full SHA for f7738a6

• Merge branch 'master' into lib-618-accesscontrol-admin-rules

  ernestognw

  committed
  e2eb45d

  Copy full SHA for e2eb45d

• Correctly set unlocked crite

  ernestognw

  committed
  68adaf5

  Copy full SHA for 68adaf5

• Completed docs

  ernestognw

  committed
  0aff3ff

  Copy full SHA for 0aff3ff

• Fix linter

  ernestognw

  committed
  4090a3e

  Copy full SHA for 4090a3e

• Refactor tests so coverage is not reduced

  ernestognw

  committed
  21aacf9

  Copy full SHA for 21aacf9

Commits on Jan 30, 2023

• Address PR review comments

  ernestognw

  committed
  2863047

  Copy full SHA for 2863047

• Update contracts/access/AccessControlAdminRules.sol

  Show description for a9a3495
  

  ernestognw

  and

  Amxx

  authored
  a9a3495

  Copy full SHA for a9a3495

• Add draft-ERC5313

  ernestognw

  committed
  59f3b62

  Copy full SHA for 59f3b62

• Remove property-based test

  ernestognw

  committed
  2bfb028

  Copy full SHA for 2bfb028

• Fix typo

  ernestognw

  committed
  7ae4aa7

  Copy full SHA for 7ae4aa7

• Add IERC5313 docs

  ernestognw

  committed
  2d630c3

  Copy full SHA for 2d630c3

• Change owner for admin

  ernestognw

  committed
  192c5bc

  Copy full SHA for 192c5bc

• Call overrideable functions

  ernestognw

  committed
  021ee37

  Copy full SHA for 021ee37

Commits on Jan 31, 2023

• Update IERC5313 to final

  ernestognw

  committed
  a54dd2b

  Copy full SHA for a54dd2b

• Reword private function

  ernestognw

  committed
  85cff36

  Copy full SHA for 85cff36

• Remove property test again

  ernestognw

  committed
  8baa13b

  Copy full SHA for 8baa13b

• Rename again

  ernestognw

  committed
  fb895d2

  Copy full SHA for fb895d2

Commits on Feb 4, 2023

• Merge branch 'master' into lib-618-accesscontrol-admin-rules

  ernestognw

  authored
  3fbfbac

  Copy full SHA for 3fbfbac

Commits on Feb 8, 2023

• Merge branch 'master' into lib-618-accesscontrol-admin-rules

  ernestognw

  authored
  b70ae34

  Copy full SHA for b70ae34

Commits on Feb 16, 2023

• Update .changeset/silent-dancers-type.md

  Show description for d120c1d
  

  ernestognw

  and

  frangio

  authored
  d120c1d

  Copy full SHA for d120c1d

• Update contracts/access/AccessControl.sol

  Show description for 4322ed7
  

  ernestognw

  and

  frangio

  authored
  4322ed7

  Copy full SHA for 4322ed7

• Update docs/modules/ROOT/pages/access-control.adoc

  Show description for d52b371
  

  ernestognw

  and

  frangio

  authored
  d52b371

  Copy full SHA for d52b371

• Rename to defaultAdmin

  ernestognw

  committed
  54184af

  Copy full SHA for 54184af

• Update contracts/access/AccessControlAdminRules.sol

  Show description for d1064f4
  

  ernestognw

  and

  frangio

  authored
  d1064f4

  Copy full SHA for d1064f4

• Update contracts/access/AccessControlAdminRules.sol

  Show description for d352694
  

  ernestognw

  and

  frangio

  authored
  d352694

  Copy full SHA for d352694

• Rename delayedUntil

  ernestognw

  committed
  53e8087

  Copy full SHA for 53e8087

• Lint

  ernestognw

  committed
  56b5df6

  Copy full SHA for 56b5df6

• Merge branch 'master' into lib-618-accesscontrol-admin-rules

  ernestognw

  authored
  30306c3

  Copy full SHA for 30306c3

Commits on Feb 17, 2023

• Small fixes

  ernestognw

  committed
  701d341

  Copy full SHA for 701d341

• More typos and minor corrections

  ernestognw

  committed
  8ebb27b

  Copy full SHA for 8ebb27b

• Allow defaultAdmin to start transfer again

  ernestognw

  committed
  f7c6596

  Copy full SHA for f7c6596

• Add extra test

  ernestognw

  committed
  5092d70

  Copy full SHA for 5092d70

• Merge branch 'master' into lib-618-accesscontrol-admin-rules

  ernestognw

  authored
  4642a12

  Copy full SHA for 4642a12

• Rename to AccessControlDefaultAdminRules

  ernestognw

  committed
  630df0d

  Copy full SHA for 630df0d

• Removed IAccessControlDefaultAdminRules

  ernestognw

  committed
  07d12a2

  Copy full SHA for 07d12a2

Commits on Feb 18, 2023

• Add note in Extending Contracts section

  ernestognw

  committed
  41f4ba3

  Copy full SHA for 41f4ba3

Commits on Feb 21, 2023

• Update contracts/access/AccessControlDefaultAdminRules.sol

  Show description for 6da27ad
  

  ernestognw

  and

  Amxx

  authored
  6da27ad

  Copy full SHA for 6da27ad

• Fix comments example

  ernestognw

  committed
  4b39c30

  Copy full SHA for 4b39c30

• Add virtual to delay()

  ernestognw

  committed
  da8227f

  Copy full SHA for da8227f

• Replace _delay with getter

  ernestognw

  committed
  6139905

  Copy full SHA for 6139905

• Add IAccessControlDefaultAdmin back

  ernestognw

  committed
  f420162

  Copy full SHA for f420162

• Created interal functions for beginning and accepting transfers

  ernestognw

  committed
  8747bf4

  Copy full SHA for 8747bf4

• Merge branch 'master' into lib-618-accesscontrol-admin-rules

  ernestognw

  authored
  444908c

  Copy full SHA for 444908c

• Update contracts/access/AccessControlDefaultAdminRules.sol

  Show description for 5743d7a
  

  ernestognw

  and

  frangio

  authored
  5743d7a

  Copy full SHA for 5743d7a

• Update contracts/access/AccessControlDefaultAdminRules.sol

  Show description for 0b9ea0b
  

  ernestognw

  and

  frangio

  authored
  0b9ea0b

  Copy full SHA for 0b9ea0b

Commits on Feb 22, 2023

• Fixed test error message

  ernestognw

  committed
  780e901

  Copy full SHA for 780e901

• Change delay to defaultAdminDelay

  ernestognw

  committed
  24ce7fa

  Copy full SHA for 24ce7fa

• Merge branch 'master' into lib-618-accesscontrol-admin-rules

  ernestognw

  authored
  a8bbf18

  Copy full SHA for a8bbf18

• Change long variable name

  ernestognw

  committed
  2c4e15e

  Copy full SHA for 2c4e15e

• Run prettier

  ernestognw

  committed
  d171299

  Copy full SHA for d171299

• Remove IAccessControlDefaultAdminRules from docs

  ernestognw

  committed
  281209c

  Copy full SHA for 281209c

• Remove camel case from error messages

  ernestognw

  committed
  2c49a5d

  Copy full SHA for 2c49a5d

• Update test/access/AccessControl.behavior.js

  Show description for cb98ad9
  

  ernestognw

  and

  frangio

  authored
  cb98ad9

  Copy full SHA for cb98ad9

• Update test/access/AccessControl.behavior.js

  Show description for 88168be
  

  ernestognw

  and

  frangio

  authored
  88168be

  Copy full SHA for 88168be

• Use beforeEach in begin transfer tests

  ernestognw

  committed
  39d176a

  Copy full SHA for 39d176a

• Update test/access/AccessControl.behavior.js

  Show description for 9e52530
  

  ernestognw

  and

  frangio

  authored
  9e52530

  Copy full SHA for 9e52530

• Update test/access/AccessControl.behavior.js

  Show description for 4721d63
  

  ernestognw

  and

  frangio

  authored
  4721d63

  Copy full SHA for 4721d63

• Update contracts/access/AccessControlDefaultAdminRules.sol

  Show description for 0e532c7
  

  ernestognw

  and

  frangio

  authored
  0e532c7

  Copy full SHA for 0e532c7

• Update contracts/access/AccessControlDefaultAdminRules.sol

  Show description for 70c5cae
  

  ernestognw

  and

  frangio

  authored
  70c5cae

  Copy full SHA for 70c5cae

• Update contracts/access/AccessControlDefaultAdminRules.sol

  Show description for 667e3da
  

  ernestognw

  and

  frangio

  authored
  667e3da

  Copy full SHA for 667e3da

• Remove unnecessary async

  ernestognw

  committed
  5a31431

  Copy full SHA for 5a31431

• Change is met for has passed

  ernestognw

  committed
  14994be

  Copy full SHA for 14994be

• Change note in docs

  ernestognw

  committed
  fd64f5d

  Copy full SHA for fd64f5d

• Update contracts/access/AccessControlDefaultAdminRules.sol

  Show description for 9e04336
  

  ernestognw

  and

  frangio

  authored
  9e04336

  Copy full SHA for 9e04336

• Simplify renouncing tests

  ernestognw

  committed
  ac093f4

  Copy full SHA for ac093f4

• Extend cancel tests

  ernestognw

  committed
  3948246

  Copy full SHA for 3948246

• Rename delay test variables

  ernestognw

  committed
  34ed74f

  Copy full SHA for 34ed74f

• Remove confusing comment

  ernestognw

  committed
  880ac0b

  Copy full SHA for 880ac0b

• Replace met with passed

  ernestognw

  committed
  3337f61

  Copy full SHA for 3337f61

• Simplified acceptance tests

  ernestognw

  committed
  a43abe7

  Copy full SHA for a43abe7

• Add IAccessControlEnumerable interface removed accidentally from docs

  ernestognw

  committed
  b4ee08a

  Copy full SHA for b4ee08a

• Merge branch 'master' into lib-618-accesscontrol-admin-rules

  ernestognw

  authored
  b2b9e81

  Copy full SHA for b2b9e81

Commits on Feb 24, 2023

• Merge branch 'master' into lib-618-accesscontrol-admin-rules

  frangio

  authored
  d1289a2

  Copy full SHA for d1289a2

• fix flaky tests

  frangio

  committed
  7d37c81

  Copy full SHA for 7d37c81

• lint

  frangio

  committed
  b164929

  Copy full SHA for b164929