Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building on Android #372

Merged
merged 2 commits into from
Apr 25, 2020
Merged

Conversation

araczkowski
Copy link
Contributor

Hi,
we are able to compile and run open-zwave on Android:
OpenZWave/open-zwave#2178

this will allow to compile node-openzwave-shared on Android

@ekarak
Copy link
Member

ekarak commented Apr 25, 2020

seems that the Appveyor CI is failing because it uses Node 8 whereas some dependency is requiring Node 10... let me see if I can fix this for you

@ekarak
Copy link
Member

ekarak commented Apr 25, 2020

@ekarak
Copy link
Member

ekarak commented Apr 25, 2020

OK this seems to have worked, I'll now merge this into master and you will need to rebase.

@ekarak
Copy link
Member

ekarak commented Apr 25, 2020

Ok done: #373
please rebase your branch to include this change on appveyor.yaml

@araczkowski
Copy link
Contributor Author

@ekarak let me know if we should improve something

The solution was tested on Android (see below), and in fact it is a copy & paste from "OS=='linux'"

$ pwd
/data/data/pl.sviete.dom/files/home/node-openzwave-shared
$ npm install

> openzwave-shared@1.6.2 preinstall /data/data/pl.sviete.dom/files/home/node-openzwave-shared
> node lib/install-ozw.js


> openzwave-shared@1.6.2 install /data/data/pl.sviete.dom/files/home/node-openzwave-shared
> node-gyp rebuild

make: Entering directory '/data/data/pl.sviete.dom/files/home/node-openzwave-shared/build'
  CXX(target) Release/obj.target/openzwave_shared/src/callbacks.o
  CXX(target) Release/obj.target/openzwave_shared/src/openzwave.o
  CXX(target) Release/obj.target/openzwave_shared/src/openzwave-config.o
  CXX(target) Release/obj.target/openzwave_shared/src/openzwave-driver.o
  CXX(target) Release/obj.target/openzwave_shared/src/openzwave-groups.o
  CXX(target) Release/obj.target/openzwave_shared/src/openzwave-management.o
  CXX(target) Release/obj.target/openzwave_shared/src/openzwave-network.o
  CXX(target) Release/obj.target/openzwave_shared/src/openzwave-nodes.o
  CXX(target) Release/obj.target/openzwave_shared/src/openzwave-polling.o
  CXX(target) Release/obj.target/openzwave_shared/src/openzwave-scenes.o
  CXX(target) Release/obj.target/openzwave_shared/src/openzwave-values.o
  CXX(target) Release/obj.target/openzwave_shared/src/utils.o
  SOLINK_MODULE(target) Release/obj.target/openzwave_shared.node
clang-8: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument]
  COPY Release/openzwave_shared.node
make: Leaving directory '/data/data/pl.sviete.dom/files/home/node-openzwave-shared/build'
npm WARN openzwave-shared@1.6.2 license should be a valid SPDX license expression

audited 158 packages in 248.36s
found 0 vulnerabilities

pull from node-openzwave-shared master
@ekarak ekarak merged commit 21e1516 into OpenZWave:master Apr 25, 2020
@ekarak
Copy link
Member

ekarak commented Apr 25, 2020

thank you Andrzej!

@araczkowski
Copy link
Contributor Author

Thanks and have a good day!

BTW
now zwave2mqtt works on Android, my goal for today is done ;)

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants