feat(difftest): add output optional parameter for dramsim3 and database #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poemonsense
reviewed
Mar 12, 2025
| @@ -97,6 +97,7 @@ static inline void print_help(const char *file) { | |||
| #ifdef ENABLE_CHISEL_DB | |||
| printf(" --dump-db enable database dump\n"); | |||
| printf(" --dump-select-db select database's table to dump\n"); | |||
| printf(" --db-path the directory used to store the database\n"); | |||
There was a problem hiding this comment.
Could you please separate this argument from this PR?
It is better to have separate PRs for dramsim3 and ChiselDB
poemonsense
reviewed
Mar 12, 2025
| @@ -145,6 +147,7 @@ inline EmuArgs parse_args(int argc, const char *argv[]) { | |||
| { "sim-run-ahead", 0, NULL, 0 }, | |||
| { "dump-db", 0, NULL, 0 }, | |||
| { "dump-select-db", 1, NULL, 0 }, | |||
| { "db-path", 1, NULL, 0 }, | |||
There was a problem hiding this comment.
Since this struct can differ from the --help strings, there's no need to add this argument here. You can simply append this argument at the end of the argument list. Then there won't be such large code changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameter --dramsim3-outdir, --db-path