Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timing(icache): restore the relaxation of ICG for icache data #4255

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

my-mayfly
Copy link
Collaborator

@my-mayfly my-mayfly commented Feb 10, 2025

Revert #4246

@my-mayfly my-mayfly requested a review from eastonman February 10, 2025 10:07
@my-mayfly my-mayfly requested a review from ngc7331 as a code owner February 10, 2025 10:07
@my-mayfly
Copy link
Collaborator Author

Based on the feedback from the physical backend, perhaps relaxing the clock gating of the data can achieve better timing results.

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 5adf4cd

commit astar copy_and_run coremark gcc gromacs hmmer-Vector lbm linux mcf microbench milc namd povray wrf xalancbmk
5adf4cd 1.819 0.442 2.634 1.239 2.144 1.498 2.145 2.359 0.943 1.388 1.998 3.101 2.555 2.272 3.300

master branch:

commit astar copy_and_run coremark gcc gromacs hmmer-Vector lbm linux mcf microbench milc namd povray wrf xalancbmk
4b9ddb8 1.819 0.442 2.634 1.235 2.144 1.498 2.145 2.359 0.943 1.380 1.998 3.101 2.555 2.272 3.300
4aeb0b1 1.819 0.442 2.634 1.232 2.144 1.498 2.145 2.359 0.943 1.380 1.998 3.101 2.555 2.272 3.300
9e12e8e 1.819 0.442 2.634 1.241 2.144 1.498 2.145 2.359 0.943 1.388 1.998 3.101 2.555 2.272 3.300
5f84a7f 1.819 0.442 2.634 1.236 2.144 1.498 2.145 2.359 0.943 1.380 1.998 3.101 2.555 2.272 3.300
c590fb3 1.819 0.442 2.634 1.233 2.144 1.498 2.145 2.359 0.943 1.388 1.998 3.101 2.555 2.272 3.300
981114e 1.819 0.442 2.634 1.231 2.144 1.498 2.145 2.359 0.943 1.380 1.998 3.101 2.555 2.272 3.300
f5217f4 1.819 0.442 2.634 1.235 2.144 1.498 2.145 2.359 0.943 1.380 1.998 3.101 2.555 2.272 3.300
977ac3b 1.819 0.442 2.634 1.231 2.144 1.498 2.145 2.359 0.943 1.388 1.998 3.101 2.555 2.272 3.300
75efee3 1.819 0.442 2.634 1.223 2.144 1.498 2.145 2.359 0.943 1.388 1.998 3.101 2.555 2.272 3.300

@Gao-Zeyu Gao-Zeyu merged commit fa84f22 into OpenXiangShan:master Feb 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants