Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify .../scriptStorage.js in sendMeta to trim up .meta.js route text to barebone keys/blocks #725

Closed
Martii opened this issue Aug 29, 2015 · 5 comments · Fixed by #765
Closed
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.

Comments

@Martii
Copy link
Member

Martii commented Aug 29, 2015

@sizzlemctwizzle wrote:

Although trimming it down in the future to @name, @namespace, @version should be a goal.

Followup from #718

Let's give some time to migrate any scripts that may need/want to use the JSON route and some time to weigh in on this. (adding needs discussion to this during this waiting time... I'm at +1 unless otherwise convinced... and I can presume @sizzlemctwizzle is at +1 by his statement)

Loosely related to:

@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. later A long time ahead, in a galaxy near, near... needs discussion Blah, blah, blah, wahh, wahh, wahh, etc. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Aug 29, 2015
@Martii
Copy link
Member Author

Martii commented Sep 30, 2015

@elundmark
We could use your expertise here on why you are inserting some unique keys in that don't pertain to sizzles suggested values. Doesn't mean you have to use it but would be grateful for your input on this issue. TIA. :)

@ghost
Copy link

ghost commented Sep 30, 2015

@Martii - You must have the wrong name, or am I going senile? :-)

@Martii
Copy link
Member Author

Martii commented Sep 30, 2015

@elundmark
LOL! You aren't going senile... was curious about some of your "rolled meta" values that you put into your consolidation of @updateURL versus what OpenUserJS.org (OUJS) offers now and what this issue is going to offer in the meta.js routine. The meta.json routine should always have everything we collect but "trimming up the fat", so to speak, for all the .user.js engines is a goal with this issue. :)

@ghost
Copy link

ghost commented Sep 30, 2015

Sorry, am I missing something here? I don't remember ever contributing to this project, which is confusing the hell out of me.

But since I just yesterday edited that very meta key in a couple of my userscripts, are you asking me why I write @updateURL and @downloadURL like this?

// @updateURL     http://f.3r1k.se/js/tz-aio/tz-aio.meta.js
// @downloadURL   http://f.3r1k.se/js/tz-aio/tz-aio.user.js

I can't see what is so unusual about it?

My bad if I'm acting weird or anything, it just that:

  • English isn't my first language
  • I live "off the grid" plus I rarely if ever interact with anyone on the net.
  • My knowledge in programming is pretty much limited to javascript.

@Martii
Copy link
Member Author

Martii commented Sep 30, 2015

am I missing something here?

I am asking for your input/feedback on why you add certain keys to your .meta.js file such as the one you mentioned at http://f.3r1k.se/js/tz-aio/tz-aio.meta.js with:

// ==UserScript==
// @name          Torrentz All-in-One
// @version       2.9.8
// @date          2015-09-28
// @namespace     http://elundmark.se/code/tz-aio/
// @homepage      https://github.com/elundmark/tz-aio-userscript
// @downloadURL   http://f.3r1k.se/js/tz-aio/tz-aio.user.js
// @updateURL   http://f.3r1k.se/js/tz-aio/tz-aio.meta.js
// ==/UserScript==

To more precisely ask the question... why did you choose to include @date, @homepage, @downloadURL, @updateURL in your .meta.js file? Do some user script engines require those for update checks? This issue ticket is to trim down the excess from the meta.js routine we offer directly at OUJS.

I don't remember ever contributing to this project

We've all been watching everyone for how they do things perhaps to incorporate some improvements into the site. I thought with your expertise you could at least comment on what you might want to see. :)

English isn't my first language

C++ is my first language. ;)... there are always translators if you feel more comfortable reading those.

I can't see what is so unusual about it?

Don't worry... we aren't as paranoid as other sites as you may have recently encountered elsewhere but we are still cautious with consolidation... but that isn't the point of me inviting you here. I just thought you might enjoy sharing your advice. :) Contributions don't necessarily entail Code but can include methodology.

Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 7, 2015
* Placing `@version` first in output for possible target speed access ... technically this should be all we need to respond with but the `@name` and `@namespace` are good for site validation
* Might consider at a later date putting `@author` in when it lands in GM since usernames could change on some sites and our metadata block `@author` as well

Closes OpenUserJS#725
@Martii Martii self-assigned this Oct 7, 2015
@Martii Martii removed later A long time ahead, in a galaxy near, near... needs discussion Blah, blah, blah, wahh, wahh, wahh, etc. labels Oct 7, 2015
Martii pushed a commit to Martii/UserScripts that referenced this issue Oct 8, 2015
* Refocus on .meta.json by shortening .meta.js Ace box for OpenUserJS/OpenUserJS.org#725
@Martii Martii removed their assignment Oct 8, 2015
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Development

Successfully merging a pull request may close this issue.

1 participant