Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Some GitHub icons #186

Closed
sizzlemctwizzle opened this issue Jun 18, 2014 · 4 comments · Fixed by #381
Closed

Use Some GitHub icons #186

sizzlemctwizzle opened this issue Jun 18, 2014 · 4 comments · Fixed by #381
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.

Comments

@sizzlemctwizzle
Copy link
Member

They've been released at http://octicons.github.com/
Here's how to use them: http://octicons.github.com/usage/
Repository at https://github.com/github/octicons

They're actually a font so they look good at any resolution and use very little space.
@Martii
Copy link
Member

Martii commented Jun 18, 2014

-1 (vehemently) if it blocked by NoScript by default and requires connection to GH with or without a cookie download. I haven't had a chance to see if googleusercontent.com (and maybe cloudflare.com requiring JavaScript to show ... IDK yet) is doing this with the icons from Zrens UI improvement in #103. It's already bad enough that I have to tell everyone to allow that font in order to use ACE editor now.

@sizzlemctwizzle
Copy link
Member Author

No we put the necessary files on our site. I don't even think GH is giving us the option to use the files hosted by them.

@Martii
Copy link
Member

Martii commented Jun 18, 2014

we put the files on our site.

Okay then. At least we'll be able to see if GH has them optimized. ;)

@Martii Martii mentioned this issue Jun 29, 2014
Closed
@Martii
Copy link
Member

Martii commented Jul 12, 2014

@sizzlemctwizzle
Are these just for availability or do you have somewhere in mind? Replacement? Augmentation on GH importing/forking? where?

@Martii Martii added the later label Jul 16, 2014
This was referenced Sep 3, 2014
Closed
Merged
@Martii Martii self-assigned this Oct 20, 2014
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 21, 2014
Add Octicons v2.1.2 to OUJS
09dd321 
* Currently static copy/extract in `/dist/octicons` since some, if not all, `npm` has some issues with static linking to GH repos on multiple platforms... this may change down the line and be dynamically linked in.
* Once again relative urls found in CSS so shouldn't be distributed in our separated public folders.
* Add actual "repo-fork" icon to script pages that are forked from another OUJS script page.
* Change READEME.md to reflect,

Feel free to use the classes at will.

Closes OpenUserJS#186
@Martii Martii mentioned this issue Oct 21, 2014
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 21, 2014
Flip URL order for Octicons in README.md
dbc076a 
Applies to OpenUserJS#381 and OpenUserJS#186
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 21, 2014
Scale back standard Octicons class to 14px instead of default of 16px
08318da 
* Rendered font-awesome fonts show about this size according to computed

Applies to OpenUserJS#381 and OpenUserJS#186
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 21, 2014
Inherit font size from container to match font-awesome default CSS rule
923bdc6 
Applies to OpenUserJS#381 and OpenUserJS#186
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 21, 2014
Create a pseudo octicon class to match font-awesome CSS properties
b627500 
* This lines up the icons with fa a little better
* Add class to view

Applies to OpenUserJS#381 and OpenUserJS#186
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 21, 2014
Move fork icon to list title
a917015 
Applies to OpenUserJS#381 and OpenUserJS#186
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 21, 2014
Scatter some icons around our views
dfb7107 
* Correct some grammar and typos
* Fill out some regions affected with more text and linkage

Applies to OpenUserJS#381 and OpenUserJS#186

**NOTE** I could lose more sleep doing this all night but I think this is officially PR READY and need some slumber.
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 22, 2014
Some doc related stuff
5e30026 
* Spread some more icons around
* Add max file size upload value to mustache and show on script/lib upload page as an info alert. Mentioned at #OpenUserJS#360 (comment)

Applies to OpenUserJS#186
@Martii Martii mentioned this issue Oct 22, 2014
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 22, 2014
Change doc icon to book instead
cf4dc7e 
Applies to OpenUserJS#186
@Martii Martii mentioned this issue Oct 22, 2014
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 22, 2014
More icon fixes
3736ab1 
* Octicon info button looks aweful compared to fa... so switching
* Doc tweak on grammar
* Add missing info button to repo list page
* Correct icon for add library in the user tools panel
* Improve code tag breaking when viewport is super small on add script/lib page ... `word-break: break-all;` doesn't appear to work this round with scaling... but leaving in for the time being.
* Apply same rule for OpenUserJS#342 line breaking ... again doesn't appear to work this round of testing but should.
* Add icons to comment popup
* Add icon to user tools
* Add icon to Danger Zone
* Add icons to Admin section
* Add icons to source code editor save button... retro here with the diskette ;) Flip to using button tag instead of input tag.
* Add icon to edit profile
* Add icon to edit script info
* Match text in new script page for forking
* Fix trash can icon in delete script
* Add icon in delete script
* Add fa-fw class to general reply button (the blue one) for symmetry on all buttons save for the md editor which doesn't have this one for preview by default
* Add fa-fw class to new issue and correct from info to success for symmetry

There's probably more but this should be the bulk of them.

Applies to OpenUserJS#186
@Martii Martii mentioned this issue Oct 22, 2014
Merged
@Martii Martii removed their assignment Oct 23, 2014
@Martii Martii removed the later A long time ahead, in a galaxy near, near... label Feb 9, 2015
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Nov 1, 2016
Some dep updates
99e6033 
* Please read their CHANGELOGs
* Fix dead links for *octicons* ... author name change detected for redirect. See below notes.
* Bump project requirements to latest LTS
* *bundler* gem update
* Add README.md refs for OpenUserJS#1021 and OpenUserJS#1031
* Delete op retested

**NOTES**
*octicons* has gone svg and no longer a font type in the next major rev... Awaiting further detailed analysis before dep update. Related to OpenUserJS#186
@Martii Martii mentioned this issue Nov 1, 2016
Merged
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Octicons v2.1.2 to OUJS Martii/OpenUserJS.org
2 participants
@sizzlemctwizzle @Martii