Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the locations button on rich data panel #267

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Updating the locations button on rich data panel #267

merged 4 commits into from
Mar 2, 2021

Conversation

emre2038
Copy link
Contributor

@emre2038 emre2038 commented Mar 1, 2021 •
edited by milafrerichs
Loading

Description

Applying the design changes on the locations button on rich data panel

Related Issue

How to test it locally

Screenshots

image

Changelog

Added

Updated

Removed

Checklist

  • 🚀 is the code ready to be merged and go live?
  • 🛠 does it work (build) locally
  • 👩‍🎨 does the design matches the Demo

Pull Request

  • 📰 good title
  • 📝good description
  • 🔖 issue linked
  • 📖 changelog filled out
  • commit messages are meaningful

Code Quality

  • 🚧 no commented out code
  • 🖨 no unnecessary logging
  • 🎱 no magic numbers

Testing

  • ✅ added (appropriate) unit tests
  • 💢 edge cases in tests were considered
  • ✅ ran tests locally & are passing

@netlify
Copy link

netlify bot commented Mar 1, 2021 •
edited
Loading

Deploy preview for wazimap-staging ready!

Built with commit 023edc1

https://deploy-preview-267--wazimap-staging.netlify.app

@milafrerichs milafrerichs marked this pull request as ready for review March 2, 2021 10:25
@milafrerichs milafrerichs merged commit 9949afa into OpenUpSA:staging Mar 2, 2021
@emre2038 emre2038 deleted the locations_button_update branch March 3, 2021 06:59
@milafrerichs milafrerichs linked an issue Mar 3, 2021 that may be closed by this pull request
Rich data view: Reposition the "facilities" button to the left or make it look more like a clickable button. #265
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rich data view: Reposition the "facilities" button to the left or make it look more like a clickable button.
2 participants
@emre2038 @milafrerichs