Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block to prevent editing of studies shared with curation app? #126

Open
jimallman opened this issue Jun 9, 2014 · 5 comments
Open

Comments

@jimallman
Copy link
Member

@pmidford, we're talking about whether it's possible to move the block on editing "shared" studies (those available to both phylografter and the new curation app) to block them on phylografter. It seems like we could do this by querying oti to see if the current study's ID is already there, yes?

The reason we're interested in this is that there are some "downstream" edits (prep for synthesis) that can't currently be done in phylografter, like:

  • re-rooting (and marking of roots as meaningful)
  • marking one or more trees as "preferred"
@mtholder
Copy link
Member

mtholder commented Jun 9, 2014

since we were talking about adding new studies in the new tool, and frequently importing to the new curator from pg, would this block all edits in phylografter? Would there be any IDs not in oti?

@pmidford
Copy link
Contributor

pmidford commented Jun 9, 2014

I don't think it would be difficult to implement such a block; I agree with Mark that this might block all edits in Phylografter, unless there was also a block so that some studies in phylografter would not get picked up by oti (so someone could start editing a new study in phylografter and release it when they were ready to use the curator tool or to offer it for synthesis).

@jimallman
Copy link
Member Author

Hm, yes. Maybe an explicit "hand-off" from one to the other? Argh, it's all half measures.

How far are we from robust sharing between both tools?

@pmidford
Copy link
Contributor

pmidford commented Jun 9, 2014

On 6/9/14, 5:49 PM, Jim Allman wrote:

Hm, yes. Maybe an explicit "hand-off" from one to the other? Argh,
it's all half measures.

How far are we from robust sharing between both tools?

Good question. I'd like to think weeks, but I've been thinking that for
a while now. Phylografter ingest from phylesystem seems to be working,
but still rather slow. There are a couple of changes in phylografter
#121 that I will be finishing up early tomorrow. There are a couple of
things Mark identified that I need to add to phylografter (mostly
capturing SHA's from ingested studies). Then I can set up the 'chron'
job on the phylografter side and we can try an update from a dev
phylesystem that has studies that were written by the curator tool and
round trip to make sure everything the curator tool expects to see is in
the right place.

Error handling is also important, both recognizing errors (our API
documentation doesn't have much to say about this) and what phylografter
should do if it can't push an update back to phylesystem.

Those are the issues I'm aware of that are holding us back.

-Peter


Reply to this email directly or view it on GitHub
#126 (comment).

@jimallman
Copy link
Member Author

Those are the issues I'm aware of that are holding us back.

No pressure, I was just wondering. Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants