Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate events iCalendar file #17

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Generate events iCalendar file #17

merged 1 commit into from
Feb 27, 2017

Conversation

pniedzielski
Copy link
Contributor

This patch adds a generated iCalendar file at the URL
/events/calendar.ics and links to it from the home page and events
page. The description field isn't always nice looking, but it's the
best I've been able to get it.

The generated iCalendar was validated with this online
validator
.

@lidavidm
Copy link
Member

Do you know why Github's diff shows the entire index.html as modified? It doesn't look any different but it's curious.

@pniedzielski
Copy link
Contributor Author

Hm. When I open it up in my editor, it tells me that the file is using DOS style line endings. I don't know how they got there, but maybe it changed all the line endings to DOS, and that's what the diff is? There should be one line changed there.

I'm going to dos2unix the file, push as a separate commit, and if that looks okay, then I'll squash them together before merging and after you approve.

@pniedzielski
Copy link
Contributor Author

That did it. Weird.

I'll squash those two together and force push.

This patch adds a generated iCalendar file at the URL
`/events/calendar.ics` and links to it from the home page and events
page.  The description field isn't always nice looking, but it's the
best I've been able to get it.

The generated iCalendar was validated with [this online
validator][validator].

[validator]: https://icalendar.org/validator.html
@lidavidm lidavidm merged commit a4cfd42 into OpenSourceCornell:master Feb 27, 2017
@lidavidm
Copy link
Member

Looks good, thanks Patrick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants