Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update count() agar sesuai dengan PHP ver 7.2 #30

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Update count() agar sesuai dengan PHP ver 7.2 #30

merged 3 commits into from
Nov 11, 2020

Conversation

roaddee
Copy link
Contributor

@roaddee roaddee commented Aug 15, 2020

Update agar sesuai dengan PHP Versi 7.2, terkait penggunaan count((array) $res)

@roaddee
Update count() agar sesuai dengan PHP ver 7.2
e32fa78 
Update agar sesuai dengan PHP Versi 7.2, terkait penggunaan count((array) $res)
@eddieridwan
Copy link
Contributor

Apakah ada contoh file anggaran realisasi yg bisa saya coba upload?
Memang PHP 7.2 akan error kalau variable untuk count belum di set. Sepertinya solusi if (! empty($res)) { akan lebih aman. Juga perhatikan bahwa ada masalah serupa di baris 135.

roaddee
roaddee commented Aug 18, 2020
View reviewed changes
Copy link
Contributor Author

@roaddee roaddee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdh saya ganti pak

@roaddee
Copy link
Contributor Author

roaddee commented Aug 18, 2020

Apakah ada contoh file anggaran realisasi yg bisa saya coba upload?
Memang PHP 7.2 akan error kalau variable untuk count belum di set. Sepertinya solusi if (! empty($res)) { akan lebih aman. Juga perhatikan bahwa ada masalah serupa di baris 135.

untuk contoh ada di folder storage/app/public, saya pakai itu

roaddee
roaddee commented Aug 18, 2020
View reviewed changes
Copy link
Contributor Author

@roaddee roaddee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juga sudah saya update yang dibaris 135

@eddieridwan eddieridwan merged commit 36c806b into OpenSID:master Nov 11, 2020
@eddieridwan
Copy link
Contributor

@roaddee , terima kasih. Sdh digabung ke master.

@BubySaputra BubySaputra mentioned this pull request Aug 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddieridwan eddieridwan eddieridwan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roaddee @eddieridwan