Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize nested directory paths from annexed objects to eliminate failure to resolve '..' in symlinked paths #2770

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Feb 13, 2023

Includes a new test to cover this situation. This affects any nested annexed paths accessed with a commit identifier but I added a history step in the test since that wasn't covered and could have been related.

Fixes #2769

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #2770 (49b09ad) into master (8494816) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2770   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files         412      412           
  Lines       66996    66996           
  Branches     2042     2042           
=======================================
  Hits        50941    50941           
  Misses      16004    16004           
  Partials       51       51           
Impacted Files Coverage Δ
services/datalad/datalad_service/handlers/files.py 72.34% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nellh nellh merged commit d6c9c1c into master Feb 14, 2023
@nellh nellh deleted the 2769-missing-annexed-file branch February 14, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web UI downloads failing for annexed files removed in draft
2 participants