Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix php7.4 syntax deprecated warnings #859

Merged
merged 1 commit into from
Jan 21, 2020
Merged

fix php7.4 syntax deprecated warnings #859

merged 1 commit into from
Jan 21, 2020

Conversation

Flyingmana
Copy link
Contributor

PHP Deprecated: Array and string offset access syntax with curly braces
is deprecated

see #829

@Flyingmana
fix php7.4 syntax deprecated warnings
bc32373 
PHP Deprecated:  Array and string offset access syntax with curly braces
is deprecated
@Flyingmana Flyingmana added this to the PHP 7.4 milestone Nov 24, 2019
@kkrieger85
Copy link
Contributor

https://wiki.php.net/rfc/deprecate_curly_braces_array_access

kkrieger85
kkrieger85 approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is only changing array braces

@kkrieger85 kkrieger85 added the review needed Problem should be verified label Nov 25, 2019
@Flyingmana Flyingmana merged commit fb9daf3 into OpenMage:1.9.4.x Jan 21, 2020
@sreichel sreichel added PHP7 and removed review needed Problem should be verified labels May 11, 2020
@sreichel sreichel added PHP 7.x Related to PHP 7.x and removed PHP7 labels Jun 5, 2020
@sreichel sreichel mentioned this pull request Jun 18, 2020
Closed
@sreichel sreichel modified the milestones: PHP 7.4, Release 19.4.1 Jun 27, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
@Flyingmana @edannenberg
[bug-OpenMage#859] Curly brace syntax for array access is deprecated …
12d2889 
…with PHP 7.4
This was referenced Sep 3, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@kkrieger85 kkrieger85 kkrieger85 approved these changes

@Vinai Vinai Awaiting requested review from Vinai

@sreichel sreichel Awaiting requested review from sreichel

Assignees
No one assigned
Labels
PHP 7.x Related to PHP 7.x
Projects
None yet
Milestone
Release 19.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Flyingmana @kkrieger85 @colinmollenhour @sreichel