Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed obsolete module Mage_Centinel #3971

Merged
merged 11 commits into from
May 7, 2024
Merged

Removed obsolete module Mage_Centinel #3971

merged 11 commits into from
May 7, 2024

Conversation

fballiano
Copy link
Contributor

This PR targets next

Mage_Centinel is a module that provided 3DS for payment methods in OpenMage. We're talking about 3DS 1.0, not 3DS 2.0 which is more or less mandatory for all credit card providers all over the world nowadays.

I've conducted quite a few tests and I'm pretty sure the module is not working anymore, when you enable it you will have this error message:
Screenshot 2024-05-02 alle 23 24 06

The XmlParser class is a reserved name in php8:
Screenshot 2024-05-02 alle 23 24 17

Also if you remove that class from the filesystem you will see:
Screenshot 2024-05-02 alle 23 24 32

So:

  • 3DS 1.0 is obsolete and nobody should use it anymore, continuing to use the outdated Centinel module would expose merchants to potential security risks and compatibility issues with modern payment systems and regulations.
  • the name "Centinel" doesn't really exist since 2011, when CardinalCommerce was acquired by Visa and the Centinel service became part of Visa's product offerings under the name "Visa Secure"
  • the Centinel module is actually broken and doesn't technically work anymore

I think it's safe to remove this code from OpenMage v21.

Closes #3755

@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Template : admin Relates to admin template Component: Sales Relates to Mage_Sales Template : rwd Relates to rwd template Template : base Relates to base template Component: Adminhtml Relates to Mage_Adminhtml Component: Payment Relates to Mage_Payment Component: Centinel Relates to Mage_Centinel Component: Paygate Relates to Mage_Paygate Component: lib/* Relates to lib/* translations Relates to app/locale JavaScript Relates to js/* XML Layout PHPStorm labels May 2, 2024
*
* @return string
*/
private function _getOrderId()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and following functions don't seem to have anything to do with Centinel. Is it ok to delete?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, I didn't remove them at first but phpstan started complaining, you can see it here:
https://github.com/OpenMage/magento-lts/actions/runs/8931953986/job/24534948827

because those methods are private and not used so they should be un-usable by anybody

I think

@kiatng
Copy link
Contributor

kiatng commented May 3, 2024

Also need to cleanup here
image
image
image

@fballiano
Copy link
Contributor Author

@kiatng done! thanks for noticing!

@luigifab
Copy link
Contributor

luigifab commented May 4, 2024

Buy buy Centinel! Disabled for me.

Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://docs.adyen.com/online-payments/3d-secure-for-regulation-compliance/

3-D Secure 1 and related technology are no longer supported by all major cards.

@fballiano fballiano merged commit ac2f4fa into OpenMage:next May 7, 2024
18 checks passed
@fballiano fballiano deleted the centinelisdead branch May 7, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Centinel Relates to Mage_Centinel Component: Core Relates to Mage_Core Component: lib/* Relates to lib/* Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales JavaScript Relates to js/* next-only phpstan PHPStorm Template : admin Relates to admin template Template : base Relates to base template Template : rwd Relates to rwd template translations Relates to app/locale XML Layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants