-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed obsolete module Mage_Centinel #3971
Conversation
* | ||
* @return string | ||
*/ | ||
private function _getOrderId() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and following functions don't seem to have anything to do with Centinel. Is it ok to delete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, I didn't remove them at first but phpstan started complaining, you can see it here:
https://github.com/OpenMage/magento-lts/actions/runs/8931953986/job/24534948827
because those methods are private and not used so they should be un-usable by anybody
I think
@kiatng done! thanks for noticing! |
Buy buy Centinel! Disabled for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://docs.adyen.com/online-payments/3d-secure-for-regulation-compliance/
3-D Secure 1 and related technology are no longer supported by all major cards.
This PR targets
next
Mage_Centinel is a module that provided 3DS for payment methods in OpenMage. We're talking about 3DS 1.0, not 3DS 2.0 which is more or less mandatory for all credit card providers all over the world nowadays.
I've conducted quite a few tests and I'm pretty sure the module is not working anymore, when you enable it you will have this error message:

The XmlParser class is a reserved name in php8:

Also if you remove that class from the filesystem you will see:

So:
I think it's safe to remove this code from OpenMage v21.
Closes #3755