Removed decorate*() js functions

[fballiano]

M1 had 4 decorate*() javascript functions, that are used (mostly) to add even/odd classes to HTML tables and things like that. The removal of these functions was discussed a couple of times already:

• (BC) Removed IE compatibility #1073 (comment)
• Deprecate decorate*() JS functions #3043
  but I think that in 2023 we should work on this.

This PR:

• removes all the calls to decorate*() funcions from the phtml templates
• deprecates the 4 javascript functions in js/varien/js.js and empties the function "body"

Since the functions are not removed by this PR it's technically not a breaking change but... it changes the final rendering of the pages so... I'd still merge this in the next branch.

This could also be considered a small step forwards removing prototypejs.

Fixes #3043

[addison74]

I agree. Do you have in plan a replacement to keep the same behavior?

[fballiano]

not at the moment (didn't have time yet) but I think it could be added :-)

[addison74]

It is fine to set this PR as a draft until there is a solution adapted to our days fir what we are removing here.

[fballiano]

"restore the same behavior" only means checking that RWD has correct CSS classes for even/odd styling (because the base theme doesn't have styling anyway), but I think that in RWD we didn't have even/odd styles already, check these couple of screenshot that are taken from the main branch:

you can see there was no even/odd styling already

[addison74]

This could also be considered a small step forwards removing prototypejs.

At some point we may be able to do this, but I'm worried about the extensions that use this library. I have so far five in production, either I should make a conversion to jQuery (the fastest way) or to JavaScript (a little more complicated and time-consuming).

If I don't adopt any of the solutions, then I can keep the library and add it manually for functionality. What if we removed everything that is old in OpenMage, including this library and it would be added by those who need it with Composer?

[fballiano]

the functions are still there, so there will be no break, but yes you'll lose the functionality. I think that who really needs these functions can just copy them and put them in their javascripts ;-) although for sure somebody has created a library for that.

[sreichel]

but yes you'll lose the functionality

Should even/odd/first/last be added to CSS-files to keep current output?

[loekvangool]

Should even/odd/first/last be added to CSS-files to keep current output?

I think they were talking about removing Prototype.js as a whole, which would lead to issues with 3rd party extension beyond CSS classes.

[fballiano]

Should even/odd/first/last be added to CSS-files to keep current output?

RWD doesn't have even/odd stripes already, as shown in the screenshots.

[loekvangool]

RWD doesn't have even/odd stripes already, as shown in the screenshots.

There is an impact, but it's mostly marginal.

[fballiano]

@loekvangool the only one is in skin/adminhtml/default/default/boxes.css (the other ones as alread CSS based even/odd ;-)) I can for sure take a look at skin/adminhtml/default/default/boxes.css no problem

[loekvangool]

There are a couple more hits in boxes.css, but yeah it's barely anything.

There's also a CSS class zebra-table that does it the CSS way, but it looks unused.

[sreichel]

Should even/odd/first/last be added to CSS-files to keep current output?

RWD doesn't have even/odd stripes already, as shown in the screenshots.

Your're right for RWD, but PR removes it from "base" template.

I know other themes have been removed, but i know some stores that rely on modern theme ... is this a sure shot?

[fballiano]

base template doesn't have CSS so we can't add any CSS to that, and it makes no sense in 2023 to add even odd classes via php.

nth-child is extremely widely supported since years: https://www.w3schools.com/CSSref/sel_nth-child.php

and we're talking about "next".

[fballiano]

RWD doesn't have even/odd stripes already, as shown in the screenshots.

There is an impact, but it's mostly marginal.

@loekvangool seems grids work fine anyway with this PR:

because those even/odd classes are injected via PHP, so I'd say there's should be nothing to add to this PR.

[loekvangool]

Indeed

[sreichel]

"nth-child" ... this is why i asked for. I thought even/odd/... has to be changed in CSS files.

[addison74]

I have not tested this PR and I will not approve it without being convinced that the change is mandatory. Those functions apply to many classes/IDs of some elements in the page. For example class/ID "product_comparison", I need to see the effect in the browser before and after the change. All these elements may need to be added to the CSS/SCSS files to keep the decoration effect.

[fballiano]

I don't think there's anything that could be added in the CSS, base doesn't have css, adminhtml and rwd don't use that functionality.
also, this PR targets next, where I think it's correct to remove 100 javascript calls that were needed years ago but it's much more performant to do the same thing via css instead of js.

[kyrena]

Can I suggest a console.warn('decorateXyz is deprecated'); to force developers to update code?

[fballiano]

After #3526 got merged maybe we can merge this one in the next branch ;-)