-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue with wysiwyg editor re-creating thumbnails #261
Conversation
…ing performance / database connection limit issues.
… > Shipping when totals don't match for Paypal
This PR includes a non-related commit (the one related to PayPal). If you fix the PR then we can evaluate the fix for inclusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the PayPal related changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'd recommend squashing when merging to prevent conflicts with the other PR if/when it gets merged.
+1 squashing is a recommendation.. and seems to block the merge. How about we merge seeing this is from 1 year ago. |
I can confirm that this problem still exists, but i'm not sure if this fix is complete. If i have time for it, i'll check end maybe open new PR or approve this one. |
Fixes issue with wysiwyg editor always re-creating thumbnails, causing performance / database connection limit issues.
Fixes issue with wysiwyg editor always re-creating thumbnails, causing performance / database connection limit issues.
Fixes issue with wysiwyg editor always re-creating thumbnails, causing performance / database connection limit issues.
Fixes issue with wysiwyg editor always re-creating thumbnails, causing performance / database connection limit issues.
Fixes issue with wysiwyg editor always re-creating thumbnails, causing performance / database connection limit issues.
Fixes issue with wysiwyg editor always re-creating thumbnails, causing performance / database connection limit issues.
Fixes issue with wysiwyg editor always re-creating thumbnails, causing performance / database connection limit issues.
Fixes issue with wysiwyg editor always re-creating thumbnails, causing performance / database connection limit issues.
This causes performance / database connection limit issues when using the media manager as the existing thumbnails aren't found to exist.