Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with wysiwyg editor re-creating thumbnails #261

Merged
merged 3 commits into from
Mar 9, 2018

Conversation

trabulium
Copy link
Contributor

This causes performance / database connection limit issues when using the media manager as the existing thumbnails aren't found to exist.

…ing performance / database connection limit issues.
… > Shipping when totals don't match for Paypal
@LeeSaferite
Copy link
Contributor

This PR includes a non-related commit (the one related to PayPal). If you fix the PR then we can evaluate the fix for inclusion.

Copy link
Contributor

@LeeSaferite LeeSaferite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the PayPal related changes.

Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd recommend squashing when merging to prevent conflicts with the other PR if/when it gets merged.

@seansan
Copy link
Contributor

seansan commented Feb 8, 2018

+1 squashing is a recommendation.. and seems to block the merge. How about we merge seeing this is from 1 year ago.

@sreichel
Copy link
Contributor

sreichel commented Feb 8, 2018

I can confirm that this problem still exists, but i'm not sure if this fix is complete.

If i have time for it, i'll check end maybe open new PR or approve this one.

@colinmollenhour colinmollenhour merged commit 1863ce6 into OpenMage:1.9.3.x Mar 9, 2018
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Mar 20, 2018
Fixes issue with wysiwyg editor always re-creating thumbnails,
causing performance / database connection limit issues.
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Jul 17, 2018
Fixes issue with wysiwyg editor always re-creating thumbnails,
causing performance / database connection limit issues.
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Sep 19, 2018
Fixes issue with wysiwyg editor always re-creating thumbnails,
causing performance / database connection limit issues.
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Feb 14, 2019
Fixes issue with wysiwyg editor always re-creating thumbnails,
causing performance / database connection limit issues.
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Apr 1, 2019
Fixes issue with wysiwyg editor always re-creating thumbnails,
causing performance / database connection limit issues.
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 22, 2019
Fixes issue with wysiwyg editor always re-creating thumbnails,
causing performance / database connection limit issues.
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Oct 25, 2019
Fixes issue with wysiwyg editor always re-creating thumbnails,
causing performance / database connection limit issues.
@sreichel sreichel mentioned this pull request May 18, 2020
3 tasks
@sreichel sreichel removed the hold label Jun 1, 2020
@sreichel sreichel added the Component: Cms Relates to Mage_Cms label Jun 8, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
Fixes issue with wysiwyg editor always re-creating thumbnails,
causing performance / database connection limit issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Component: Cms Relates to Mage_Cms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants