-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong class name in Convert/Adapter/Product #2034
Conversation
Mage_Catalog_Model_Entity_Product_Collection to Mage_Catalog_Model_Resource_Product_Collection
This comment has been minimized.
This comment has been minimized.
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a logical improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is valid as required and fixes the issue documented.
Wrong DOC here ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update Mage_Adminhtml_Helper_Catalog_Product_Edit_Action_Attribute
too.
The PR #2035 contains these changes too, so maybe lets merge it first and abandon this one? |
closed in favor of: https://github.com/OpenMage/magento-lts/pull/2035/files |
Description (*)
It changes references to no existing class
Mage_Catalog_Model_Entity_Product_Collection
toMage_Catalog_Model_Resource_Product_Collection
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)