Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong class name in Convert/Adapter/Product #2034

Closed
wants to merge 1 commit into from

Conversation

tmotyl
Copy link
Contributor

@tmotyl tmotyl commented Mar 5, 2022

Description (*)

It changes references to no existing class Mage_Catalog_Model_Entity_Product_Collection to Mage_Catalog_Model_Resource_Product_Collection

Related Pull Requests

  1. Relates Analyze most of the source code with phpstan. Provide baseline. #2035

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

Mage_Catalog_Model_Entity_Product_Collection to Mage_Catalog_Model_Resource_Product_Collection
@github-actions github-actions bot added the Component: Catalog Relates to Mage_Catalog label Mar 5, 2022
@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 0272512. ± Comparison against base commit a1b01fa.

Copy link

@henryhayes henryhayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a logical improvement.

Copy link

@henryhayes henryhayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is valid as required and fixes the issue documented.

@sreichel
Copy link
Contributor

Wrong DOC here ...

class Mage_Adminhtml_Helper_Catalog_Product_Edit_Action_Attribute extends Mage_Core_Helper_Data
{
    /**
     * Selected products for mass-update
     *
     * @var Mage_Catalog_Model_Entity_Product_Collection
     */
    protected $_products;

Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Mage_Adminhtml_Helper_Catalog_Product_Edit_Action_Attribute too.

@tmotyl
Copy link
Contributor Author

tmotyl commented Mar 10, 2022

The PR #2035 contains these changes too, so maybe lets merge it first and abandon this one?

@tmotyl
Copy link
Contributor Author

tmotyl commented Apr 11, 2022

@tmotyl tmotyl closed this Apr 11, 2022
@fballiano fballiano deleted the class-type-adapter-product branch June 1, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Relates to Mage_Catalog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants